Patch "USB: cypress_m8: add endpoint sanity check" has been added to the 3.14-stable tree

This is a note to let you know that I've just added the patch titled

USB: cypress_m8: add endpoint sanity check

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-cypress_m8-add-endpoint-sanity-check.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Oliver Neukum <[email protected]>
Date: Thu, 31 Mar 2016 12:04:25 -0400
Subject: USB: cypress_m8: add endpoint sanity check

From: Oliver Neukum <[email protected]>

commit c55aee1bf0e6b6feec8b2927b43f7a09a6d5f754 upstream.

An attack using missing endpoints exists.

CVE-2016-3137

---
 drivers/usb/serial/cypress_m8.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

@@ -447,6 +447,11 @@ static int cypress_generic_port_probe(st
 	struct usb_serial *serial = port->serial;
 	struct cypress_private *priv;
 
+	if (!port->interrupt_out_urb || !port->interrupt_in_urb) {
+		dev_err(&port->dev, "required endpoint is missing\n");
+		return -ENODEV;
+	}
+
 	priv = kzalloc(sizeof(struct cypress_private), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;

@@ -606,12 +611,6 @@ static int cypress_open(struct tty_struc
 		cypress_set_termios(tty, port, &priv->tmp_termios);
 
 	/* setup the port and start reading from the device */
-	if (!port->interrupt_in_urb) {
-		dev_err(&port->dev, "%s - interrupt_in_urb is empty!\n",
-			__func__);
-		return -1;
-	}
-
 	usb_fill_int_urb(port->interrupt_in_urb, serial->dev,
 		usb_rcvintpipe(serial->dev, port->interrupt_in_endpointAddress),
 		port->interrupt_in_urb->transfer_buffer,

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/usb-cdc-acm-more-sanity-checking.patch queue-3.14/usb-mct_u232-add-sanity-checking-in-probe.patch queue-3.14/usb-digi_acceleport-do-sanity-checking-for-the-number-of-ports.patch queue-3.14/usb-cypress_m8-add-endpoint-sanity-check.patch queue-3.14/usb-retry-reset-if-a-device-times-out.patch queue-3.14/usb-hub-fix-a-typo-in-hub_port_init-leading-to-wrong-logic.patch queue-3.14/usb-usb_driver_claim_interface-add-sanity-checking.patch