Skip to contentSkip to conversation

Patch "Input: powermate - fix oops with malicious USB descriptors" has been added to the 4.5-stable tree

PATCH [email protected] 1 participant 1 message Apr 9, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: powermate - fix oops with malicious USB descriptors

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-powermate-fix-oops-with-malicious-usb-descriptors.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9c6ba456711687b794dcf285856fc14e2c76074f Mon Sep 17 00:00:00 2001

From: Josh Boyer <[email protected]>
Date: Mon, 14 Mar 2016 09:33:40 -0700
Subject: Input: powermate - fix oops with malicious USB descriptors

From: Josh Boyer <[email protected]>

commit 9c6ba456711687b794dcf285856fc14e2c76074f upstream.

The powermate driver expects at least one valid USB endpoint in its probe function. If given malicious descriptors that specify 0 for the number of endpoints, it will crash. Validate the number of endpoints on the interface before using them.

The full report for this issue can be found here:
http://seclists.org/bugtraq/2016/Mar/85

---
 drivers/input/misc/powermate.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/input/misc/powermate.c +3 -0
@@ -307,6 +307,9 @@ static int powermate_probe(struct usb_in
 	int error = -ENOMEM;
 
 	interface = intf->cur_altsetting;
+	if (interface->desc.bNumEndpoints < 1)
+		return -EINVAL;
+
 	endpoint = &interface->endpoint[0].desc;
 	if (!usb_endpoint_is_int_in(endpoint))
 		return -EIO;

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/usb-serial-ftdi_sio-add-support-for-icp-das-i-756xu-devices.patch queue-4.5/input-powermate-fix-oops-with-malicious-usb-descriptors.patch queue-4.5/perf-tools-fix-python-extension-build.patch queue-4.5/usb-iowarrior-fix-oops-with-malicious-usb-descriptors.patch