Skip to contentSkip to conversation

Patch "mei: bus: check if the device is enabled before data transfer" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 9, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mei: bus: check if the device is enabled before data transfer

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mei-bus-check-if-the-device-is-enabled-before-data-transfer.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 15c13dfcad883a1e76b714480fb27be96247fd82 Mon Sep 17 00:00:00 2001

From: Alexander Usyskin <[email protected]>
Date: Sun, 7 Feb 2016 23:35:32 +0200
Subject: mei: bus: check if the device is enabled before data transfer

From: Alexander Usyskin <[email protected]>

commit 15c13dfcad883a1e76b714480fb27be96247fd82 upstream.

The bus data transfer interface was missing the check if the device is in enabled state, this may lead to stack corruption during link reset.

---
 drivers/misc/mei/bus.c |    9 +++++++++
 1 file changed, 9 insertions(+)
drivers/misc/mei/bus.c +9 -0
@@ -53,6 +53,11 @@ ssize_t __mei_cl_send(struct mei_cl *cl,
 	bus = cl->dev;
 
 	mutex_lock(&bus->device_lock);
+	if (bus->dev_state != MEI_DEV_ENABLED) {
+		rets = -ENODEV;
+		goto out;
+	}
+
 	if (!mei_cl_is_connected(cl)) {
 		rets = -ENODEV;
 		goto out;
@@ -109,6 +114,10 @@ ssize_t __mei_cl_recv(struct mei_cl *cl,
 	bus = cl->dev;
 
 	mutex_lock(&bus->device_lock);
+	if (bus->dev_state != MEI_DEV_ENABLED) {
+		rets = -ENODEV;
+		goto out;
+	}
 
 	cb = mei_cl_read_cb(cl, NULL);
 	if (cb)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mei-bus-check-if-the-device-is-enabled-before-data-transfer.patch