Patch "mtip32xx: Fix broken service thread handling" has been added to the 4.5-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
mtip32xx: Fix broken service thread handling
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mtip32xx-fix-broken-service-thread-handling.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
cfc05bd31384c4898bf2437a4de5557f3cf9803aMon Sep 17 00:00:00 2001
From: Asai Thambi SP <[email protected]>
Date: Wed, 24 Feb 2016 21:16:00 -0800
Subject: mtip32xx: Fix broken service thread handling
From: Asai Thambi SP <[email protected]>
commit cfc05bd31384c4898bf2437a4de5557f3cf9803a upstream.
Service thread does not detect the need for taskfile error hanlding. Fixed the flag condition to process taskfile error.
--- drivers/block/mtip32xx/mtip32xx.c | 6 +++--- drivers/block/mtip32xx/mtip32xx.h | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-)
drivers/block/mtip32xx/mtip32xx.c +3 -3
@@ -2917,9 +2917,7 @@ static int mtip_service_thread(void *dat* is in progress nor error handling is active */ wait_event_interruptible (port->svc_wait, (port->flags) && - !(port->flags &MTIP_PF_PAUSE_IO )); - -set_bit (MTIP_PF_SVC_THD_ACTIVE_BIT , &port->flags); + (port->flags &MTIP_PF_SVC_THD_WORK ));if (kthread_should_stop () ||test_bit (MTIP_PF_SVC_THD_STOP_BIT , &port->flags))
@@ -2929,6 +2927,8 @@ static int mtip_service_thread(void *dat &dd->dd_flag))) goto st_out; +set_bit (MTIP_PF_SVC_THD_ACTIVE_BIT , &port->flags); + restart_eh:/* Demux bits: start with error handling */ if (test_bit (MTIP_PF_EH_ACTIVE_BIT , &port->flags)) {
drivers/block/mtip32xx/mtip32xx.h +5 -0
@@ -144,6 +144,11 @@ enum {MTIP_PF_REBUILD_BIT =6 ,MTIP_PF_SVC_THD_STOP_BIT =8 , +MTIP_PF_SVC_THD_WORK = ((1 <<MTIP_PF_EH_ACTIVE_BIT ) | + (1 <<MTIP_PF_ISSUE_CMDS_BIT ) | + (1 <<MTIP_PF_REBUILD_BIT ) | + (1 <<MTIP_PF_SVC_THD_STOP_BIT )), +/* below are bit numbers in 'dd_flag' defined in driver_data */ MTIP_DDF_SEC_LOCK_BIT =0 , MTIP_DDF_REMOVE_PENDING_BIT = 1,
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/mtip32xx-print-exact-time-when-an-internal-command-is-interrupted.patch queue-4.5/mtip32xx-implement-timeout-handler.patch queue-4.5/mtip32xx-cleanup-queued-requests-after-surprise-removal.patch queue-4.5/mtip32xx-avoid-issuing-standby-immediate-cmd-during-ftl-rebuild.patch queue-4.5/mtip32xx-handle-safe-removal-during-io.patch queue-4.5/mtip32xx-remove-unwanted-code-from-taskfile-error-handler.patch queue-4.5/mtip32xx-handle-ftl-rebuild-failure-state-during-device-initialization.patch queue-4.5/mtip32xx-fix-for-rmmod-crash-when-drive-is-in-ftl-rebuild.patch queue-4.5/mtip32xx-fix-broken-service-thread-handling.patch