Patch "ALSA: hda - Fix spurious kernel WARNING on Baytrail HDMI" has been added to the 4.5-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ALSA: hda - Fix spurious kernel WARNING on Baytrail HDMI
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-hda-fix-spurious-kernel-warning-on-baytrail-hdmi.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
93a9ff151754fbdf951b1b993bcf96453f6e36b3Mon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Fri, 18 Mar 2016 19:45:13 +0100
Subject: ALSA: hda - Fix spurious kernel WARNING on Baytrail HDMI
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Takashi Iwai <[email protected]>
commit 93a9ff151754fbdf951b1b993bcf96453f6e36b3 upstream.
snd_hdac_sync_audio_rate() call is mandatory only for HSW and later models, but we call the function unconditionally blindly assuming that the function doesn't do anything harmful. But since recently, the function checks the validity of the passed pin NID, and eventually spews the warning if an unexpected pin is passed. This is seen on old chips like Baytrail.
The fix is to limit the call of this function again only for the chips with the proper binding. This can be identified by the same flag as the eld notifier.
--- sound/pci/hda/patch_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
sound/pci/hda/patch_hdmi.c +2 -1
@@ -1873,7 +1873,8 @@ static int generic_hdmi_playback_pcm_pre/* Call sync_audio_rate to set the N/CTS/M manually if necessary */ /* Todo: add DP1.2 MST audio support later */ -snd_hdac_sync_audio_rate (&codec->bus->core, pin_nid, runtime->rate); +if (codec_has_acomp (codec)) +snd_hdac_sync_audio_rate (&codec->bus->core, pin_nid, runtime->rate); non_pcm =check_non_pcm_per_cvt (codec, cvt_nid);mutex_lock (&per_pin->lock);
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/alsa-hda-apply-reboot-d3-fix-for-cx20724-codec-too.patch queue-4.5/alsa-intel8x0-add-clock-quirk-entry-for-ad1981b-on-ibm-thinkpad-x41.patch queue-4.5/alsa-hda-add-new-gpu-codec-id-0x10de0082-to-snd-hda.patch queue-4.5/alsa-hda-limit-i915-hdmi-binding-only-for-hsw-and-later.patch queue-4.5/alsa-hda-fix-unexpected-resume-through-regmap-code-path.patch queue-4.5/alsa-hda-fix-missing-eld-update-at-unplugging.patch queue-4.5/alsa-hda-really-restrict-i915-notifier-to-hsw.patch queue-4.5/alsa-usb-audio-add-microsoft-hd-5001-to-quirks.patch queue-4.5/alsa-hda-workaround-for-unbalanced-i915-power-refcount-by-concurrent-probe.patch queue-4.5/alsa-usb-audio-fix-null-dereference-in-create_fixed_stream_quirk.patch queue-4.5/alsa-hda-fix-spurious-kernel-warning-on-baytrail-hdmi.patch queue-4.5/alsa-usb-audio-minor-code-cleanup-in-create_fixed_stream_quirk.patch queue-4.5/alsa-pcm-avoid-bug-string-for-warnings-again.patch queue-4.5/alsa-usb-audio-fix-double-free-in-error-paths-after-snd_usb_add_audio_stream-call.patch queue-4.5/alsa-hda-fix-unconditional-gpio-toggle-via-automute.patch queue-4.5/alsa-hda-don-t-handle-eld-notify-from-invalid-port.patch queue-4.5/alsa-usb-audio-add-sanity-checks-for-endpoint-accesses.patch queue-4.5/alsa-hda-fix-the-mic-mute-button-and-led-problem-for-a-lenovo-aio.patch queue-4.5/alsa-hda-fix-forgotten-hdmi-monitor_present-update.patch