FAILED: patch "[PATCH] fuse: do not use iocb after it may have been freed" failed to apply to 3.14-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 3.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
7cabc61e01a0a8b663bd2b4c982aa53048218734Mon Sep 17 00:00:00 2001
From: Robert Doebbelin <[email protected]>
Date: Mon, 7 Mar 2016 09:50:56 +0100
Subject: [PATCH] fuse: do not use iocb after it may have been freed
There's a race in fuse_direct_IO(), whereby is_sync_kiocb() is called on an iocb that could have been freed if async io has already completed. The fix in this case is simple and obvious: cache the result before starting io.
It was discovered by KASan:
kernel: ==================================================================
kernel: BUG: KASan: use after free in fuse_direct_IO+0xb1a/0xcc0 at addr ffff88036c414390
fs/fuse/file.c +4 -3
@@ -2843,6 +2843,7 @@ fuse_direct_IO(struct kiocb *iocb, struct iov_iter *iter, loff_t offset)loff_t i_size;size_t count =iov_iter_count (iter);struct fuse_io_priv *io; +bool is_sync =is_sync_kiocb (iocb); pos = offset; inode = file->f_mapping->host;
@@ -2882,11 +2883,11 @@ fuse_direct_IO(struct kiocb *iocb, struct iov_iter *iter, loff_t offset)* to wait on real async I/O requests, so we must submit this request * synchronously. */ -if (!is_sync_kiocb (iocb) && (offset + count > i_size) && +if (!is_sync && (offset + count > i_size) &&iov_iter_rw (iter) ==WRITE ) io->async = false; -if (io->async &&is_sync_kiocb (iocb)) +if (io->async && is_sync) io->done = &wait;if (iov_iter_rw (iter) ==WRITE ) {
@@ -2900,7 +2901,7 @@ fuse_direct_IO(struct kiocb *iocb, struct iov_iter *iter, loff_t offset)fuse_aio_complete (io, ret <0 ? ret :0 ,-1 );/* we have a non-extending, async request, so return */ -if (!is_sync_kiocb (iocb)) +if (!is_sync)return -EIOCBQUEUED ;wait_for_completion (&wait);