Patch "mmc: sdhci: fix data timeout (part 2)" has been added to the 4.5-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
mmc: sdhci: fix data timeout (part 2)
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mmc-sdhci-fix-data-timeout-part-2.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7f05538af71c7d30b5fc821cbe9f318edc645961Mon Sep 17 00:00:00 2001
From: Russell King <[email protected]>
Date: Tue, 26 Jan 2016 13:41:04 +0000
Subject: mmc: sdhci: fix data timeout (part 2)
From: Russell King <[email protected]>
commit 7f05538af71c7d30b5fc821cbe9f318edc645961 upstream.
The calculation for the timeout based on the number of card clocks is incorrect. The calculation assumed:
timeout in microseconds = clock cycles / clock in Hz
which is clearly a several orders of magnitude wrong. Fix this by multiplying the clock cycles by 1000000 prior to dividing by the Hz based clock. Also, as per part 1, ensure that the division rounds up.
As this needs 64-bit math via do_div(), avoid it if the clock cycles is zero.
--- drivers/mmc/host/sdhci.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci.c +13 -2
@@ -636,8 +636,19 @@ static u8 sdhci_calc_timeout(struct sdhc target_timeout = cmd->busy_timeout *1000 ; else { target_timeout =DIV_ROUND_UP (data->timeout_ns,1000 ); -if (host->clock) - target_timeout += data->timeout_clks / host->clock; +if (host->clock && data->timeout_clks) { +unsigned long long val; + +/* +* data->timeout_clks is in units of clock cycles. +* host->clock is in Hz. target_timeout is in us. +* Hence, us = 1000000 * cycles / Hz. Round up. +*/ + val =1000000 * data->timeout_clks; +if (do_div (val, host->clock)) + target_timeout++; + target_timeout += val; + } }/*
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/mmc-sdhci-fix-command-response-crc-error-handling.patch queue-4.5/mmc-sdhci-avoid-unnecessary-mapping-unmapping-of-align-buffer.patch queue-4.5/mmc-sdhci-move-initialisation-of-command-error-member.patch queue-4.5/mmc-sdhci-fix-data-timeout-part-2.patch queue-4.5/mmc-sdhci-clean-up-command-error-handling.patch queue-4.5/mmc-sdhci-further-fix-for-dma-unmapping-in-sdhci_post_req.patch queue-4.5/mmc-sdhci-pxav3-fix-higher-speed-mode-capabilities.patch queue-4.5/mmc-sdhci-fix-data-timeout-part-1.patch queue-4.5/mmc-sdhci-plug-dma-mapping-leak-on-error.patch