Skip to contentSkip to conversation

Patch "libnvdimm, pfn: fix uuid validation" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 12, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

libnvdimm, pfn: fix uuid validation

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
libnvdimm-pfn-fix-uuid-validation.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From e5670563f588ed1c0603819350c0f02cec23f5c5 Mon Sep 17 00:00:00 2001

From: Dan Williams <[email protected]>
Date: Thu, 7 Apr 2016 19:59:27 -0700
Subject: libnvdimm, pfn: fix uuid validation

From: Dan Williams <[email protected]>

commit e5670563f588ed1c0603819350c0f02cec23f5c5 upstream.

If we detect a namespace has a stale info block in the init path, we should overwrite with the latest configuration. In fact, we already return -ENODEV when the parent uuid is invalid, the same should be done for the 'self' uuid. Otherwise we can get into a condition where userspace is unable to reconfigure the pfn-device without directly / manually invalidating the info block.

---
 drivers/nvdimm/pfn_devs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvdimm/pfn_devs.c +1 -1
@@ -275,7 +275,7 @@ int nd_pfn_validate(struct nd_pfn *nd_pf
 	} else {
 		/* from init we validate */
 		if (memcmp(nd_pfn->uuid, pfn_sb->uuid, 16) != 0)
-			return -EINVAL;
+			return -ENODEV;
 	}
 
 	/*

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/libnvdimm-pfn-fix-uuid-validation.patch queue-4.4/libnvdimm-fix-smart-data-retrieval.patch