Skip to contentSkip to conversation

Patch "drm/udl: Use unlocked gem unreferencing" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 13, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/udl: Use unlocked gem unreferencing

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-udl-use-unlocked-gem-unreferencing.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 72b9ff0612ad8fc969b910cd00ac16b57a1a9ba4 Mon Sep 17 00:00:00 2001

From: Daniel Vetter <[email protected]>
Date: Wed, 30 Mar 2016 11:40:43 +0200
Subject: drm/udl: Use unlocked gem unreferencing

From: Daniel Vetter <[email protected]>

commit 72b9ff0612ad8fc969b910cd00ac16b57a1a9ba4 upstream.

For drm_gem_object_unreference callers are required to hold dev->struct_mutex, which these paths don't. Enforcing this requirement has become a bit more strict with

commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663

Author: Daniel Vetter <[email protected]>
Date:   Thu Oct 15 09:36:25 2015 +0200

drm/gem: Check locking in drm_gem_object_unreference

---
 drivers/gpu/drm/udl/udl_fb.c  |    2 +-
 drivers/gpu/drm/udl/udl_gem.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/udl/udl_fb.c +1 -1
@@ -539,7 +539,7 @@ static int udlfb_create(struct drm_fb_he
 out_destroy_fbi:
 	drm_fb_helper_release_fbi(helper);
 out_gfree:
-	drm_gem_object_unreference(&ufbdev->ufb.obj->base);
+	drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base);
 out:
 	return ret;
 }
drivers/gpu/drm/udl/udl_gem.c +1 -1
@@ -52,7 +52,7 @@ udl_gem_create(struct drm_file *file,
 		return ret;
 	}
 
-	drm_gem_object_unreference(&obj->base);
+	drm_gem_object_unreference_unlocked(&obj->base);
 	*handle_p = handle;
 	return 0;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/drm-dp-move-hw_mutex-up-the-call-stack.patch queue-4.4/drm-udl-use-unlocked-gem-unreferencing.patch