Skip to contentSkip to conversation

platform/chrome: cros_ec_dev - Populate compat_ioctl

PATCH Applied Guenter Roeck 3 participants 3 messages Apr 15, 2016 – May 11, 2016

Subsystems (2)
ChromeOS EC subdrivers Chrome hardware platform support
lore
Share & tools
lore

Guenter Roeck

author
#0 lore raw

PATCH 1/1 platform/chrome: cros_ec_dev - Populate compat_ioctl

compat_ioctl has to be populated for 32 bit userspace applications to work with 64 bit kernels.

Signed-off-by Guenter Roeck <[email protected]>
---
 drivers/platform/chrome/cros_ec_dev.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/platform/chrome/cros_ec_dev.c +3 -0
index 6c45e0f5ba7b..903b1d8dcab7 100644
@@ -208,6 +208,9 @@ static const struct file_operations fops = {
 	.release = ec_device_release,
 	.read = ec_device_read,
 	.unlocked_ioctl = ec_device_ioctl,
+#ifdef CONFIG_COMPAT
+	.compat_ioctl = ec_device_ioctl,
+#endif
 };
 
 static void __remove(struct device *dev)
Signature · 1 line
2.5.0
Tested-by on v1 1/1
#1 lore raw
Quoted 4 lines · Guenter Roeck

compat_ioctl has to be populated for 32 bit userspace applications to work with 64 bit kernels.

Signed-off-by Guenter Roeck <[email protected]>

Tested with 32-bit user space on ARM64:

Tested-by Brian Norris <[email protected]>
Quoted 18 lines

---
drivers/platform/chrome/cros_ec_dev.c | 3 +++

 1 file changed, 3 insertions(+)
drivers/platform/chrome/cros_ec_dev.c +3 -0
index 6c45e0f5ba7b..903b1d8dcab7 100644
@@ -208,6 +208,9 @@ static const struct file_operations fops = {
 	.release = ec_device_release,
 	.read = ec_device_read,
 	.unlocked_ioctl = ec_device_ioctl,
+#ifdef CONFIG_COMPAT
+	.compat_ioctl = ec_device_ioctl,
+#endif
 };
 
 static void __remove(struct device *dev)