Skip to contentSkip to conversation

Patch "Revert bad backport of "drm/radeon: hold reference to fences in radeon_sa_bo_new"" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Apr 18, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Revert bad backport of "drm/radeon: hold reference to fences in radeon_sa_bo_new"

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
revert-bad-backport-of-drm-radeon-hold-reference-to-fences-in-radeon_sa_bo_new.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Apr 18 10:31:57 JST 2016

Date: Mon, 18 Apr 2016 10:31:57 +0900
To: Greg KH <[email protected]>
From: Greg Kroah-Hartman <[email protected]>
Subject: Revert bad backport of "drm/radeon: hold reference to fences in radeon_sa_bo_new"

From: Greg Kroah-Hartman <[email protected]>

This reverts commit 50353e6f86eb2ac46ffe3cc0b9f9a11ddc8a9410, which is commit f6ff4f67cdf8455d0a4226eeeaf5af17c37d05eb upstream, as it was backported to the 3.14-stable tree incorrectly. A correct fix will happen next.

---
 drivers/gpu/drm/radeon/radeon_sa.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/radeon/radeon_sa.c +0 -5
@@ -349,13 +349,8 @@ int radeon_sa_bo_new(struct radeon_devic
 			/* see if we can skip over some allocations */
 		} while (radeon_sa_bo_next_hole(sa_manager, fences, tries));
 
-		for (i = 0; i < RADEON_NUM_RINGS; ++i)
-			radeon_fence_ref(fences[i]);
-
 		spin_unlock(&sa_manager->wq.lock);
 		r = radeon_fence_wait_any(rdev, fences, false);
-		for (i = 0; i < RADEON_NUM_RINGS; ++i)
-			radeon_fence_unref(&fences[i]);
 		spin_lock(&sa_manager->wq.lock);
 		/* if we have nothing to wait for block */
 		if (r == -ENOENT && block) {

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/ipv4-fix-broadcast-packets-reception.patch queue-3.14/ext4-add-lockdep-annotations-for-i_data_sem.patch queue-3.14/qlge-fix-receive-packets-drop.patch queue-3.14/drm-radeon-add-a-dpm-quirk-for-all-r7-370-parts.patch queue-3.14/mac80211-fix-unnecessary-frame-drops-in-mesh-fwding.patch queue-3.14/0001-drm-radeon-hold-reference-to-fences-in-radeon_sa_bo_.patch queue-3.14/revert-bad-backport-of-drm-radeon-hold-reference-to-fences-in-radeon_sa_bo_new.patch queue-3.14/parisc-fix-kernel-crash-with-reversed-copy_from_user.patch queue-3.14/perf-cure-event-pending_disable-race.patch queue-3.14/ppp-take-reference-on-channels-netns.patch queue-3.14/usbvision-fix-leak-of-usb_dev-on-failure-paths-in-usbvision_probe.patch queue-3.14/drm-radeon-add-a-dpm-quirk-for-sapphire-dual-x-r7-370-2g-d5.patch queue-3.14/ip6_tunnel-set-rtnl_link_ops-before-calling-register_netdevice.patch queue-3.14/parisc-avoid-function-pointers-for-kernel-exception-routines.patch queue-3.14/sh_eth-fix-null-pointer-dereference-in-sh_eth_ring_format.patch queue-3.14/farsync-fix-off-by-one-bug-in-fst_add_one.patch queue-3.14/qmi_wwan-add-d-link-dwm-221-b1-device-id.patch queue-3.14/sctp-lack-the-check-for-ports-in-sctp_v6_cmp_addr.patch queue-3.14/net-fix-use-after-free-in-the-recvmmsg-exit-path.patch queue-3.14/xen-events-mask-a-moving-irq.patch queue-3.14/usb-renesas_usbhs-avoid-null-pointer-derefernce-in-usbhsf_pkt_handler.patch queue-3.14/alsa-timer-use-mod_timer-for-rearming-the-system-timer.patch queue-3.14/ipv4-l2tp-fix-a-potential-issue-in-l2tp_ip_recv.patch queue-3.14/ath9k-fix-buffer-overrun-for-ar9287.patch queue-3.14/usb-renesas_usbhs-disable-tx-irq-before-starting-tx-dmac-transfer.patch queue-3.14/usbvision-fix-overflow-of-interfaces-array.patch queue-3.14/ipv6-l2tp-fix-a-potential-issue-in-l2tp_ip6_recv.patch queue-3.14/usbnet-cleanup-after-bind-in-probe.patch queue-3.14/net-jme-fix-suspend-resume-on-jmc260.patch queue-3.14/udp6-fix-udp-ipv6-encap-resubmit-path.patch queue-3.14/usbvision-fix-crash-on-detecting-device-with-invalid-configuration.patch queue-3.14/ipv6-re-enable-fragment-header-matching-in-ipv6_find_hdr.patch queue-3.14/hid-usbhid-fix-inconsistent-reset-resume-reset-resume-behavior.patch queue-3.14/hwmon-max1111-return-enodev-from-max1111_read_channel-if-not-instantiated.patch queue-3.14/cdc_ncm-toggle-altsetting-to-force-reset-before-setup.patch queue-3.14/revert-usb-hub-do-not-clear-bos-field-during-reset-device.patch queue-3.14/mm-fix-invalid-node-in-alloc_migrate_target.patch