Skip to contentSkip to conversation

ALSA: hda/realtek - Add ALC3234 headset mode for Optiplex 9020m

PATCH Applied Bastien Nocera 2 participants 6 messages Apr 18, 2016 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/realtek - Add ALC3234 headset mode for Optiplex 9020m

The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.

A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.

Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.

With help from David Henningsson <[email protected]>

---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
index 1402ba9..810bcee 100644
@@ -5449,6 +5449,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x064a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x064b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x0665, "Dell XPS 13", ALC288_FIXUP_DELL_XPS_13),
+	SND_PCI_QUIRK(0x1028, 0x0669, "Dell Optiplex 9020m", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x069a, "Dell Vostro 5480", ALC290_FIXUP_SUBWOOFER_HSJACK),
 	SND_PCI_QUIRK(0x1028, 0x06c7, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x06d9, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
Signature · 1 line
2.7.3
Applied
#1 lore raw
Quoted 7 lines · Bastien Nocera

The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.

A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.

Quoted 8 lines

Unfortunately, pin configurations can changed based on firmware/BIOS versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.

With help from David Henningsson <[email protected]>

Applied, thanks.

Takashi

Quoted 20 lines
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
index 1402ba9..810bcee 100644
@@ -5449,6 +5449,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x064a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x064b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x0665, "Dell XPS 13", ALC288_FIXUP_DELL_XPS_13),
+	SND_PCI_QUIRK(0x1028, 0x0669, "Dell Optiplex 9020m", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x069a, "Dell Vostro 5480", ALC290_FIXUP_SUBWOOFER_HSJACK),
 	SND_PCI_QUIRK(0x1028, 0x06c7, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x06d9, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
Signature · 1 line
2.7.3
#2 lore raw
Quoted 16 lines · Takashi Iwai
Quoted 14 lines · Bastien Nocera

The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.

A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.

Unfortunately, pin configurations can changed based on firmware/BIOS
versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.

Quoted 5 lines
Quoted 4 lines

With help from David Henningsson <[email protected]>

Applied, thanks.

Thanks for the quick response. Can you however fix the typo I made?

"pin configurations can changed"
should be
"pin configurations can change"

Cheers

#3 lore raw
Quoted 22 lines · Bastien Nocera
Quoted 20 lines · Takashi Iwai
Quoted 18 lines · Bastien Nocera

The Optiplex 9020m with Haswell-DT processor needs a quirk for the headset jack at the front of the machine to be able to use microphones.

A quirk for this model was originally added in 3127899, but c77900e removed it in favour of a more generic version.

Unfortunately, pin configurations can changed based on firmware/BIOS
versions, and the generic version doesn't have any effect on newer versions of the machine/firmware anymore.

With help from David Henningsson <[email protected]>

Quoted 7 lines
Quoted 1 line

Applied, thanks.

Thanks for the quick response. Can you however fix the typo I made?

"pin configurations can changed"
should be
"pin configurations can change"

Sorry, too late, it's been already merged and published.

Takashi

#4 lore raw
Quoted 30 lines · Takashi Iwai
Quoted 28 lines · Bastien Nocera
Quoted 25 lines · Takashi Iwai
Quoted 22 lines · Bastien Nocera

The Optiplex 9020m with Haswell-DT processor needs a quirk for the
headset jack at the front of the machine to be able to use microphones.

A quirk for this model was originally added in 3127899, but c77900e
removed it in favour of a more generic version.

Unfortunately, pin configurations can changed based on firmware/BIOS
versions, and the generic version doesn't have any effect on newer
versions of the machine/firmware anymore.

With help from David Henningsson <[email protected]>

Quoted 7 lines
Quoted 6 lines
Quoted 1 line

Applied, thanks.

Thanks for the quick response. Can you however fix the typo I made?

"pin configurations can changed"
should be
"pin configurations can change"

Sorry, too late, it's been already merged and published.

Yay git :/

#5 lore raw
Quoted 33 lines · Bastien Nocera
Quoted 31 lines · Takashi Iwai
Quoted 29 lines · Bastien Nocera
Quoted 26 lines · Takashi Iwai
Quoted 18 lines · Bastien Nocera

The Optiplex 9020m with Haswell-DT processor needs a quirk for the
headset jack at the front of the machine to be able to use microphones.

A quirk for this model was originally added in 3127899, but c77900e
removed it in favour of a more generic version.

Unfortunately, pin configurations can changed based on firmware/BIOS
versions, and the generic version doesn't have any effect on newer
versions of the machine/firmware anymore.

Quoted 4 lines

With help from David Henningsson <[email protected]>

Applied, thanks.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines

Thanks for the quick response. Can you however fix the typo I made?

"pin configurations can changed"
should be
"pin configurations can change"

Sorry, too late, it's been already merged and published.

Yay git :/

If the change were catastrophically buggy, I'd revert or rebase. But in this case, it's a not-too-bad typo, so I prefer leaving it.

Takashi