Skip to contentSkip to conversation

arm: socfpga: Fix typos in DT files (environmnet -> environment)

PATCH New Stefan Roese 2 participants 4 messages Apr 18, 2016 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm: socfpga: Fix typos in DT files (environmnet -> environment)

Fix a small typo in some of the SoCFPGA dts files that has spread via copy-and-paste.

Cc Marek Vasut <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Chin Liang See <[email protected]>
---
 arch/arm/dts/socfpga_arria5_socdk.dts    | 2 +-
 arch/arm/dts/socfpga_cyclone5_socdk.dts  | 2 +-
 arch/arm/dts/socfpga_cyclone5_sr1500.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/socfpga_arria5_socdk.dts +1 -1
index 9ac48a1..7265058 100644
@@ -21,7 +21,7 @@
 	};
 
 	aliases {
-		/* this allow the ethaddr uboot environmnet variable contents
+		/* this allow the ethaddr uboot environment variable contents
 		 * to be added to the gmac1 device tree blob.
 		 */
 		ethernet0 = &gmac1;
arch/arm/dts/socfpga_cyclone5_socdk.dts +1 -1
index da13435..d4df1a1 100644
@@ -21,7 +21,7 @@
 	};
 
 	aliases {
-		/* this allow the ethaddr uboot environmnet variable contents
+		/* this allow the ethaddr uboot environment variable contents
 		 * to be added to the gmac1 device tree blob.
 		 */
 		ethernet0 = &gmac1;
arch/arm/dts/socfpga_cyclone5_sr1500.dts +1 -1
index 32c6aad..739bbb7 100644
@@ -16,7 +16,7 @@
 
 	aliases {
 		/*
-		 * This allows the ethaddr uboot environmnet variable
+		 * This allows the ethaddr uboot environment variable
 		 * contents to be added to the gmac1 device tree blob.
 		 */
 		ethernet0 = &gmac1;
Signature · 1 line
2.8.1
#1 lore raw

PATCH 2/2 arm: socfpga: socrates: Add eth0 alias to enable ethernet

This enables full ethernet usage, including U-Boot to write the board specific MAC address (ethaddr) into the DT blob before passing it to Linux.

Without this, the ethaddr is not detected in U-Boot at all, resulting in this error upon bootup:

...
Model: EBV SOCrates
Net:
Error: ethernet at ff702000 address not set.
No ethernet found.

Cc Marek Vasut <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Chin Liang See <[email protected]>
---
 arch/arm/dts/socfpga_cyclone5_socrates.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/dts/socfpga_cyclone5_socrates.dts +5 -0
index 591d96c..d2ab3b3 100644
@@ -15,6 +15,11 @@
 	};
 
 	aliases {
+		/*
+		 * This allows the ethaddr uboot environment variable
+		 * contents to be added to the gmac1 device tree blob.
+		 */
+		ethernet0 = &gmac1;
 		udc0 = &usb1;
 	};
 
Signature · 1 line
2.8.1
#2 lore raw

PATCH 2/2 arm: socfpga: socrates: Add eth0 alias to enable ethernet

Quoted 13 lines · Stefan Roese

This enables full ethernet usage, including U-Boot to write the board specific MAC address (ethaddr) into the DT blob before passing it to Linux.

Without this, the ethaddr is not detected in U-Boot at all, resulting in this error upon bootup:

...
Model: EBV SOCrates
Net:
Error: ethernet at ff702000 address not set.
No ethernet found.

Quoted 7 lines
Cc Marek Vasut <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Chin Liang See <[email protected]>
---
 arch/arm/dts/socfpga_cyclone5_socrates.dts | 5 +++++
 1 file changed, 5 insertions(+)

Thanks!

Quoted 17 lines
arch/arm/dts/socfpga_cyclone5_socrates.dts +5 -0
index 591d96c..d2ab3b3 100644
@@ -15,6 +15,11 @@
 	};
 
 	aliases {
+		/*
+		 * This allows the ethaddr uboot environment variable
+		 * contents to be added to the gmac1 device tree blob.
+		 */
+		ethernet0 = &gmac1;
 		udc0 = &usb1;
 	};
 
Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

PATCH 1/2 arm: socfpga: Fix typos in DT files (environmnet -> environment)

In reply to Stefan Roese
Quoted 7 lines · Stefan Roese

Fix a small typo in some of the SoCFPGA dts files that has spread via copy-and-paste.

Cc Marek Vasut <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Chin Liang See <[email protected]>
Quoted 46 lines
---
 arch/arm/dts/socfpga_arria5_socdk.dts    | 2 +-
 arch/arm/dts/socfpga_cyclone5_socdk.dts  | 2 +-
 arch/arm/dts/socfpga_cyclone5_sr1500.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/socfpga_arria5_socdk.dts +1 -1
index 9ac48a1..7265058 100644
@@ -21,7 +21,7 @@
 	};
 
 	aliases {
-		/* this allow the ethaddr uboot environmnet variable contents
+		/* this allow the ethaddr uboot environment variable contents
 		 * to be added to the gmac1 device tree blob.
 		 */
 		ethernet0 = &gmac1;
arch/arm/dts/socfpga_cyclone5_socdk.dts +1 -1
index da13435..d4df1a1 100644
@@ -21,7 +21,7 @@
 	};
 
 	aliases {
-		/* this allow the ethaddr uboot environmnet variable contents
+		/* this allow the ethaddr uboot environment variable contents
 		 * to be added to the gmac1 device tree blob.
 		 */
 		ethernet0 = &gmac1;
arch/arm/dts/socfpga_cyclone5_sr1500.dts +1 -1
index 32c6aad..739bbb7 100644
@@ -16,7 +16,7 @@
 
 	aliases {
 		/*
-		 * This allows the ethaddr uboot environmnet variable
+		 * This allows the ethaddr uboot environment variable
 		 * contents to be added to the gmac1 device tree blob.
 		 */
 		ethernet0 = &gmac1;
Signature · 2 lines
Best regards,
Marek Vasut