Skip to contentSkip to conversation

kms_atomic: Fix crtc_id comparison failing.

PATCH In review [email protected] 3 participants 3 messages Apr 22, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kms_atomic: Fix crtc_id comparison failing.

From: Robert Foss <[email protected]>

Fixed ctrc_id comparison failing due to bad initialization of crtc variable.

---
 tests/kms_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_atomic.c +1 -1
index 13a5db1..f27ee46 100644
@@ -1361,7 +1361,7 @@ igt_main
 
 	igt_subtest("atomic_invalid_params") {
 		struct kms_atomic_state *scratch = atomic_state_dup(current);
-		struct kms_atomic_crtc_state *crtc = &scratch->crtcs[0];
+		struct kms_atomic_crtc_state *crtc = find_crtc(scratch, true);
 		struct kms_atomic_plane_state *plane =
 			find_plane(scratch, NUM_PLANE_TYPE_PROPS, crtc);
 		struct kms_atomic_connector_state *conn =
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

You've already sent this yesterday. Its pushed.

Quoted 30 lines · On Thu, Apr 21, 2016 at 10:24:28PM -0400, [email protected] wrote:

From: Robert Foss <[email protected]>

Fixed ctrc_id comparison failing due to bad initialization of crtc variable.

---
 tests/kms_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_atomic.c +1 -1
index 13a5db1..f27ee46 100644
@@ -1361,7 +1361,7 @@ igt_main
 
 	igt_subtest("atomic_invalid_params") {
 		struct kms_atomic_state *scratch = atomic_state_dup(current);
-		struct kms_atomic_crtc_state *crtc = &scratch->crtcs[0];
+		struct kms_atomic_crtc_state *crtc = find_crtc(scratch, true);
 		struct kms_atomic_plane_state *plane =
 			find_plane(scratch, NUM_PLANE_TYPE_PROPS, crtc);
 		struct kms_atomic_connector_state *conn =
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 1 line · Marius Vlad

You've already sent this yesterday. Its pushed.

When you push patches (especially from other people), please send out a quick confirmation mail to the mailing list. Avoids confusion like this one here.
-Daniel

Quoted 39 lines · On Thu, Apr 21, 2016 at 10:24:28PM -0400, [email protected] wrote:
Quoted 30 lines

From: Robert Foss <[email protected]>

Fixed ctrc_id comparison failing due to bad initialization of crtc variable.

---
 tests/kms_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_atomic.c +1 -1
index 13a5db1..f27ee46 100644
@@ -1361,7 +1361,7 @@ igt_main
 
 	igt_subtest("atomic_invalid_params") {
 		struct kms_atomic_state *scratch = atomic_state_dup(current);
-		struct kms_atomic_crtc_state *crtc = &scratch->crtcs[0];
+		struct kms_atomic_crtc_state *crtc = find_crtc(scratch, true);
 		struct kms_atomic_plane_state *plane =
 			find_plane(scratch, NUM_PLANE_TYPE_PROPS, crtc);
 		struct kms_atomic_connector_state *conn =
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx