drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt
Subsystems (2)
PATCH 1/1 drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt.
v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen)
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +2 -3
@@ -905,11 +905,10 @@ static int gen8_init_scratch(struct i915_address_space *vm)static int gen8_ppgtt_notify_vgt (struct i915_hw_ppgtt *ppgtt,bool create) {enum vgt_g2v_type msg; -struct drm_device *dev = ppgtt->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; +struct drm_i915_private *dev_priv =to_i915 (ppgtt->base.dev);int i; -if (USES_FULL_48BIT_PPGTT (dev)) { +if (USES_FULL_48BIT_PPGTT (dev_priv)) {u64 daddr =px_dma (&ppgtt->pml4);I915_WRITE (vgtif_reg (pdp[0 ].lo),lower_32_bits (daddr));
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Matthew Auld
Remove dev local and use
to_i915()ingen8_ppgtt_notify_vgt.v2: use
dev_privdirectly forQUESTION_MACROS(Joonas Lahtinen)Cc Joonas Lahtinen <[email protected]>Signed-off-by Matthew Auld <[email protected]>Reviewed-by Joonas Lahtinen <[email protected]>
Merged, thanks for the patch.
Per Chris's comment a follow-up work might be worthy to actually make the USES_FULL_48BIT_PPGTT macro read the dev_priv structure instead of kernel module parameters.
Regards, Joonas
Quoted 22 lines
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++---1 file changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +1
-2@@ -905,11 +905,10 @@ static int gen8_init_scratch(struct i915_address_space *vm) static int gen8_ppgtt_notify_vgt(struct i915_hw_ppgtt *ppgtt, bool create) { enum vgt_g2v_type msg; -struct drm_device *dev = ppgtt->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; +struct drm_i915_private *dev_priv =to_i915 (ppgtt->base.dev); int i;drivers/gpu/drm/i915/i915_gem_gtt.c +1
-1-if (USES_FULL_48BIT_PPGTT (dev)) { +if (USES_FULL_48BIT_PPGTT (dev_priv)) {u64 daddr =
px_dma(&ppgtt->pml4);
I915_WRITE(vgtif_reg(pdp[0].lo), lower_32_bits(daddr));
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt
URL : https://patchwork.freedesktop.org/series/6152/
State : failure
== Summary ==
Series 6152v1 drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt
http://patchwork.freedesktop.org/api/1.0/series/6152/revisions/1/mbox/
Test drv_module_reload_basic:
pass -> SKIP (skl-nuci5)
Test gem_busy:
Subgroup basic-vebox:
pass -> SKIP (bsw-nuc-2)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (ilk-hp8440p) UNSTABLE
pass -> FAIL (byt-nuc)
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> INCOMPLETE (snb-dellxps)bdw-nuci7 total:193 pass:181 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23 bsw-nuc-2 total:192 pass:151 dwarn:0 dfail:0 fail:0 skip:41 byt-nuc total:192 pass:153 dwarn:0 dfail:0 fail:1 skip:38 hsw-brixbox total:193 pass:169 dwarn:0 dfail:0 fail:0 skip:24 hsw-gt2 total:193 pass:174 dwarn:0 dfail:0 fail:0 skip:19 ilk-hp8440p total:193 pass:136 dwarn:0 dfail:0 fail:0 skip:57 ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28 skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25 skl-nuci5 total:193 pass:181 dwarn:0 dfail:0 fail:0 skip:12 snb-dellxps total:174 pass:139 dwarn:0 dfail:0 fail:0 skip:34 snb-x220t total:193 pass:155 dwarn:0 dfail:0 fail:1 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_1993/
d5b5101bd09a7b7e48b1cd78fe8f8a40b21d4deb drm-intel-nightly: 2016y-04m-21d-16h-37m-06s UTC integration manifest 4212ca6 drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx