Skip to contentSkip to conversation

mozjs: fix configure host contamination

PATCH In review Mark Asselstine 2 participants 5 messages Apr 26, 2016 – Apr 27, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mozjs: fix configure host contamination

When building mozjs the following error was observed

| Traceback (most recent call last):
|   File "./config.status", line 9, in <module>
|     from ConfigStatus import config_status
|   File "/build/bitbake_build/tmp/work/corei7-64-wrs-linux/mozjs/17.0.0-r0/mozjs17.0.0/js/src/build/ConfigStatus.py", line 11, in <module>
|     import sys, re, os, posixpath, ntpath
|   File "/usr/lib/python2.7/ntpath.py", line 15, in <module>
|     from genericpath import _unicode
| ImportError: cannot import name _unicode
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_configure (log file is located at /build//bitbake_build/tmp/work/corei7-64-wrs-linux/mozjs/17.0.0-r0/temp/do_configure/log.do_configure.1056

Note the host paths found in the error msg. Further this issue can be explored using the host python, which will not error when attempting the above import, and the python in the sysroot, which will fail when we attempt the import.

By inheriting pythonnative we ensure the proper paths are set to avoid this host contamination.

---
 meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +1 -1
index be4b50b..1dc99ab 100644
@@ -21,7 +21,7 @@ SRC_URI[sha256sum] = "321e964fe9386785d3bf80870640f2fa1c683e32fe988eeb201b04471c
 
 S = "${WORKDIR}/${BPN}${PV}/js/src"
 
-inherit autotools pkgconfig perlnative
+inherit autotools pkgconfig perlnative pythonnative
 
 DEPENDS += "nspr zlib"
 
Signature · 1 line
2.1.4
#1 lore raw
Quoted 12 lines · Mark Asselstine
| Traceback (most recent call last):
|   File "./config.status", line 9, in <module>
|     from ConfigStatus import config_status
|   File
"/build/bitbake_build/tmp/work/corei7-64-wrs-linux/mozjs/17.0.0-r0/mozjs17.0.0/js/src/build/ConfigStatus.py",
line 11, in <module>
|     import sys, re, os, posixpath, ntpath
|   File "/usr/lib/python2.7/ntpath.py", line 15, in <module>
|     from genericpath import _unicode
| ImportError: cannot import name _unicode
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_configure (log file is located at
Quoted 2 lines

/build//bitbake_build/tmp/work/corei7-64-wrs-linux/mozjs/17.0.0-r0/temp/do_configure/log.do_configure.1056

I'm not sure using pythonnative is the right fix here. Executing python using the host python should just work, so why does importing ntpath fail using your host python?

What happens if you run the host python in a terminal and do "import ntpath"? Does your host's python have a crippled class library or is broken in some way?

Ross

#2 lore raw
Quoted 18 lines · Ross
Quoted 12 lines · Mark Asselstine
| Traceback (most recent call last):
|   File "./config.status", line 9, in <module>
|     from ConfigStatus import config_status
|   File
"/build/bitbake_build/tmp/work/corei7-64-wrs-linux/mozjs/17.0.0-r0/mozjs17.0.0/js/src/build/ConfigStatus.py",
line 11, in <module>
|     import sys, re, os, posixpath, ntpath
|   File "/usr/lib/python2.7/ntpath.py", line 15, in <module>
|     from genericpath import _unicode
| ImportError: cannot import name _unicode
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_configure (log file is located at
Quoted 2 lines

/build//bitbake_build/tmp/work/corei7-64-wrs-linux/mozjs/17.0.0-r0/temp/do_configure/log.do_configure.1056

Quoted 3 lines

I'm not sure using pythonnative is the right fix here. Executing python using the host python should just work, so why does importing ntpath fail using your host python?

Correct. Host python should and does work but configure is executing sysroot python and using host libraries.

Quoted 4 lines

What happens if you run the host python in a terminal and do "import ntpath"? Does your host's python have a crippled class library or is broken in some way?

Again, host python does work, it is a matter of sysroot python being executed and using host libs. So agreed there are two solutions, fix things to use host python or the fix I have proposed.

Mark

Quoted 7 lines

Ross
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 7 lines · Mark Asselstine
Quoted 3 lines

I'm not sure using pythonnative is the right fix here. Executing python using the host python should just work, so why does importing ntpath fail using your host python?

Correct. Host python should and does work but configure is executing sysroot python and using host libraries.

How is it finding and executing the sysroot python without inheriting pythonnative?

Ross

#4 lore raw
Quoted 7 lines · Ross
Quoted 4 lines · Mark Asselstine
Quoted 3 lines

I'm not sure using pythonnative is the right fix here. Executing python using the host python should just work, so why does importing ntpath fail using your host python?

Quoted 6 lines
Quoted 3 lines

Correct. Host python should and does work but configure is executing sysroot python and using host libraries.

How is it finding and executing the sysroot python without inheriting pythonnative?

I originally hit this issue when building Wind River Linux and I usually take steps to ensure these changes are applicable to non-Wind River Linux builds before sending anything out. It appears my checks have failed me. Looking again at a Yocto build I see that host python is being picked up and thus the issue does not exist.

Thanks Ross for the review.

Mark

Quoted 7 lines

Ross
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel