drm: Quiet down drm_mode_getresources
Subsystems (2)
PATCH 1/1 drm: Quiet down drm_mode_getresources
From: Tvrtko Ursulin <[email protected]>
The debug logging here can be very verbose in the kernel logs and provides no information which userspace doesn't have the access to already. Turn it off so kernel logs become more manageable.
--- drivers/gpu/drm/drm_crtc.c | 10 ---------- 1 file changed, 10 deletions(-)
drivers/gpu/drm/drm_crtc.c +0 -10
@@ -1936,8 +1936,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, copied =0 ; crtc_id = (uint32_t __user *)(unsigned long )card_res->crtc_id_ptr;drm_for_each_crtc (crtc, dev) { -DRM_DEBUG_KMS ("[CRTC:%d:%s]\n" , - crtc->base.id, crtc->name);if (put_user (crtc->base.id, crtc_id + copied)) { ret = -EFAULT ; goto out;
@@ -1952,8 +1950,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, copied =0 ; encoder_id = (uint32_t __user *)(unsigned long )card_res->encoder_id_ptr;drm_for_each_encoder (encoder, dev) { -DRM_DEBUG_KMS ("[ENCODER:%d:%s]\n" , encoder->base.id, - encoder->name);if (put_user (encoder->base.id, encoder_id + copied)) { ret = -EFAULT ;
@@ -1969,9 +1965,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, copied =0 ; connector_id = (uint32_t __user *)(unsigned long )card_res->connector_id_ptr;drm_for_each_connector (connector, dev) { -DRM_DEBUG_KMS ("[CONNECTOR:%d:%s]\n" , - connector->base.id, - connector->name);if (put_user (connector->base.id, connector_id + copied)) { ret = -EFAULT ;
@@ -1982,9 +1975,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, } card_res->count_connectors = connector_count; -DRM_DEBUG_KMS ("CRTC[%d] CONNECTORS[%d] ENCODERS[%d]\n" , card_res->count_crtcs, - card_res->count_connectors, card_res->count_encoders); - out:mutex_unlock (&dev->mode_config.mutex);return ret;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm: Quiet down drm_mode_getresources
== Series Details ==
== Series Details ==
Series: drm: Quiet down drm_mode_getresources
URL : https://patchwork.freedesktop.org/series/6397/
State : success
== Summary ==
Series 6397v1 drm: Quiet down drm_mode_getresources
http://patchwork.freedesktop.org/api/1.0/series/6397/revisions/1/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (snb-x220t)
Test gem_exec_suspend:
Subgroup basic-s3:
fail -> PASS (snb-x220t)bdw-nuci7 total:200 pass:188 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:200 pass:175 dwarn:0 dfail:0 fail:0 skip:25 bsw-nuc-2 total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 byt-nuc total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 hsw-brixbox total:200 pass:174 dwarn:0 dfail:0 fail:0 skip:26 hsw-gt2 total:200 pass:178 dwarn:0 dfail:0 fail:1 skip:21 ilk-hp8440p total:200 pass:139 dwarn:0 dfail:0 fail:0 skip:61 ivb-t430s total:200 pass:169 dwarn:0 dfail:0 fail:0 skip:31 skl-i7k-2 total:200 pass:173 dwarn:0 dfail:0 fail:0 skip:27 skl-nuci5 total:200 pass:189 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:200 pass:158 dwarn:0 dfail:0 fail:0 skip:42 snb-x220t total:200 pass:158 dwarn:0 dfail:0 fail:1 skip:41
Results at /archive/results/CI_IGT_test/Patchwork_2088/
4fa405ab5848b76c8568c7fb771d389a6695108c drm-intel-nightly: 2016y-04m-27d-10h-47m-35s UTC integration manifest a9b9fbb drm: Quiet down drm_mode_getresources
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
The debug logging here can be very verbose in the kernel logs and provides no information which userspace doesn't have the access to already. Turn it off so kernel logs become more manageable.
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Daniel Vetter <[email protected]>Acked-by Daniel Vetter <[email protected]>
Also merged this one to drm-misc, thanks.
-Daniel
Quoted 53 lines
--- drivers/gpu/drm/drm_crtc.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/drm_crtc.c +0
-10@@ -1936,8 +1936,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, copied =0 ; crtc_id = (uint32_t __user *)(unsigned long )card_res->crtc_id_ptr;drm_for_each_crtc (crtc, dev) { -DRM_DEBUG_KMS ("[CRTC:%d:%s]\n" , - crtc->base.id, crtc->name);if (put_user (crtc->base.id, crtc_id + copied)) { ret = -EFAULT ; goto out;@@ -1952,8 +1950,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, copied =0 ; encoder_id = (uint32_t __user *)(unsigned long )card_res->encoder_id_ptr;drm_for_each_encoder (encoder, dev) { -DRM_DEBUG_KMS ("[ENCODER:%d:%s]\n" , encoder->base.id, - encoder->name);if (put_user (encoder->base.id, encoder_id + copied)) { ret = -EFAULT ;@@ -1969,9 +1965,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, copied =0 ; connector_id = (uint32_t __user *)(unsigned long )card_res->connector_id_ptr;drm_for_each_connector (connector, dev) { -DRM_DEBUG_KMS ("[CONNECTOR:%d:%s]\n" , - connector->base.id, - connector->name);if (put_user (connector->base.id, connector_id + copied)) { ret = -EFAULT ;@@ -1982,9 +1975,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data, } card_res->count_connectors = connector_count; -DRM_DEBUG_KMS ("CRTC[%d] CONNECTORS[%d] ENCODERS[%d]\n" , card_res->count_crtcs, - card_res->count_connectors, card_res->count_encoders); - out:mutex_unlock (&dev->mode_config.mutex);return ret;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx