Unduplicate CHV phy code
Subsystems (2)
v4 cover Unduplicate CHV phy code
Hi,
I checked registre dumps with and without this series and noticed one difference that was actually intentional but not mentioned, so the first patch gets an updated commit message.
Also changed chv_phy_post_disable() to chv_phy_post_pll_disable() as requested by Ville.
Ander Conselvan de Oliveira (10):
drm/i915: Set crtc_state->lane_count for HDMI drm/i915: Unduplicate CHV signal level code drm/i915: Unduplicate chv_data_lane_soft_reset() drm/i915: Unduplicate CHV phy-releated pre pll enabling code drm/i915: Unduplicate CHV pre-encoder enabling phy logic drm/i915: Unduplicate CHV encoders' post pll disable code drm/i915: Unduplicate VLV signal level code drm/i915: Unduplicate VLV phy pre pll enabling code drm/i915: Unduplicate pre encoder enabling phy code drm/i915: Move VLV HDMI lane reset work around logic to
intel_dpio_phy.c
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h | 18 ++ drivers/gpu/drm/i915/intel_ddi.c | 4 +- drivers/gpu/drm/i915/intel_dp.c | 412 ++--------------------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 470 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_drv.h | 5 + drivers/gpu/drm/i915/intel_hdmi.c | 356 +------------------------ 7 files changed, 526 insertions(+), 740 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_dpio_phy.c
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 1/10 drm/i915: Set crtc_state->lane_count for HDMI
Set the lane count for HDMI to 4. This will make it easier to unduplicate CHV phy code.
This also fixes the the soft reset programming for HDMI with CHV. After commit a8f327fb8464 ("drm/i915: Clean up CHV lane soft reset programming"), it wouldn't set the right bits for PCS23 since it relied on a lane count that was never set.
v2: Set lane_count in *_get_config() to please state checker. (0day)
v3: Set lane_count for DDI in DVI mode too. (CI)
v4: Add note about CHV soft lane reset. (Ander)
--- drivers/gpu/drm/i915/intel_ddi.c | 4 +++- drivers/gpu/drm/i915/intel_hdmi.c | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +3 -1
@@ -2197,8 +2197,10 @@ void intel_ddi_get_config(struct intel_encoder *encoder,if (intel_hdmi->infoframe_enabled (&encoder->base, pipe_config)) pipe_config->has_infoframe = true; -break ; +/* fall through */ case TRANS_DDI_MODE_SELECT_DVI : + pipe_config->lane_count =4 ; +break ;case TRANS_DDI_MODE_SELECT_FDI :break ;case TRANS_DDI_MODE_SELECT_DP_SST :
drivers/gpu/drm/i915/intel_hdmi.c +4 -0
@@ -953,6 +953,8 @@ static void intel_hdmi_get_config(struct intel_encoder *encoder, dotclock /= pipe_config->pixel_multiplier; pipe_config->base.adjusted_mode.crtc_clock = dotclock; + + pipe_config->lane_count =4 ; }static void intel_enable_hdmi_audio (struct intel_encoder *encoder)
@@ -1337,6 +1339,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,/* Set user selected PAR to incoming mode's member */ adjusted_mode->picture_aspect_ratio = intel_hdmi->aspect_ratio; + pipe_config->lane_count =4 ; +return true; }
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/10 drm/i915: Unduplicate CHV signal level code
In reply to Ander Conselvan de OliveiraThe code for programming voltage swing and emphasis was duplicated between DP and HDMI code. Move that to a new file, intel_dpio_phy.c.
v2: Keep the "Use 800mV-0dB" comment in the HDMI code. (Ville)
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h | 5 ++ drivers/gpu/drm/i915/intel_dp.c | 103 ++-------------------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 122 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 70 +------------------ 5 files changed, 136 insertions(+), 165 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_dpio_phy.c
drivers/gpu/drm/i915/Makefile +1 -0
@@ -59,6 +59,7 @@ i915-y += intel_audio.o \ intel_bios.o \ intel_color.o \ intel_display.o \ + intel_dpio_phy.o \ intel_dpll_mgr.o \ intel_fbc.o \ intel_fifo_underrun.o \
drivers/gpu/drm/i915/i915_drv.h +5 -0
@@ -3577,6 +3577,11 @@ void intel_sbi_write(struct drm_i915_private *dev_priv, u16 reg, u32 value,u32 vlv_flisdsi_read (struct drm_i915_private *dev_priv,u32 reg);void vlv_flisdsi_write (struct drm_i915_private *dev_priv,u32 reg,u32 val); +/* intel_dpio_phy.c */ +void chv_set_phy_signal_level (struct intel_encoder *encoder, +u32 deemph_reg_value,u32 margin_reg_value, +bool uniq_trans_scale); +int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +6 -97
124 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dpio_phy.c new file +122 -0
122 lines not on this page · raw message
drivers/gpu/drm/i915/intel_hdmi.c +2 -68
79 lines not on this page · raw message
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 3/10 drm/i915: Unduplicate chv_data_lane_soft_reset()
In reply to Ander Conselvan de OliveiraThe function chv_data_lane_soft_reset() was duplicated in DP and HDMI code. Move it to intel_dpio_phy.c.
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_dp.c | 44 ----------------------------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 43 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 44 ----------------------------------- 4 files changed, 45 insertions(+), 88 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -3581,6 +3581,8 @@ void vlv_flisdsi_write(struct drm_i915_private *dev_priv, u32 reg, u32 val);void chv_set_phy_signal_level (struct intel_encoder *encoder,u32 deemph_reg_value,u32 margin_reg_value,bool uniq_trans_scale); +void chv_data_lane_soft_reset (struct intel_encoder *encoder, +bool reset);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +0 -44
50 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dpio_phy.c +43 -0
46 lines not on this page · raw message
drivers/gpu/drm/i915/intel_hdmi.c +0 -44
50 lines not on this page · raw message
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 4/10 drm/i915: Unduplicate CHV phy-releated pre pll enabling code
In reply to Ander Conselvan de OliveiraThe same logic is used for DP and HDMI so move it to intel_dpio_phy.c.
v2: Rebase
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 83 +---------------------------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 81 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_drv.h | 5 +++ drivers/gpu/drm/i915/intel_hdmi.c | 74 +------------------------------ 5 files changed, 89 insertions(+), 155 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -3583,6 +3583,7 @@ void chv_set_phy_signal_level(struct intel_encoder *encoder, bool uniq_trans_scale);void chv_data_lane_soft_reset (struct intel_encoder *encoder,bool reset); +void chv_phy_pre_pll_enable (struct intel_encoder *encoder);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +1 -82
97 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dpio_phy.c +81 -0
84 lines not on this page · raw message
drivers/gpu/drm/i915/intel_drv.h +5 -0
@@ -1337,6 +1337,11 @@ bool intel_dp_source_supports_hbr2(struct intel_dp *intel_dp);bool intel_dp_get_link_status (struct intel_dp *intel_dp,uint8_t link_status[DP_LINK_STATUS_SIZE ]); +static inline unsigned int intel_dp_unused_lane_mask (int lane_count) +{ +return ~((1 << lane_count) -1 ) &0xf ; +} +/* intel_dp_aux_backlight.c */ int intel_dp_aux_init_backlight_funcs (struct intel_connector *intel_connector);
drivers/gpu/drm/i915/intel_hdmi.c +1 -73
82 lines not on this page · raw message
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 5/10 drm/i915: Unduplicate CHV pre-encoder enabling phy logic
In reply to Ander Conselvan de OliveiraThe only difference between the DP and HDMI versions was the lane count. Since lane_count is now set appropriately for HDMI too, get rid of the duplication and move this to intel_dpio_phy.c
v2: Don't move comments about 2nd common lane staying alive. (Ville)
--- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/intel_dp.c | 83 +------------------------------ drivers/gpu/drm/i915/intel_dpio_phy.c | 92 +++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 67 +------------------------ 4 files changed, 98 insertions(+), 146 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -3584,6 +3584,8 @@ void chv_set_phy_signal_level(struct intel_encoder *encoder,void chv_data_lane_soft_reset (struct intel_encoder *encoder,bool reset);void chv_phy_pre_pll_enable (struct intel_encoder *encoder); +void chv_phy_pre_encoder_enable (struct intel_encoder *encoder); +void chv_phy_release_cl2_override (struct intel_encoder *encoder);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +2 -81
93 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dpio_phy.c +92 -0
95 lines not on this page · raw message
drivers/gpu/drm/i915/intel_hdmi.c +2 -65
80 lines not on this page · raw message
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 6/10 drm/i915: Unduplicate CHV encoders' post pll disable code
In reply to Ander Conselvan de OliveiraThe exact same code was used by HDMI and DP encoders, so move it to intel_dpio_phy.c.
v2: Fix typo in the commit message. (Jim Bride)
v3: Call the new function chv_phy_post_pll_disable() instead of
chv_phy_post_disable(), as it should be called after the pll is disabled. (Ville)
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 30 +----------------------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 33 +++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 30 +----------------------------- 4 files changed, 36 insertions(+), 58 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -3586,6 +3586,7 @@ void chv_data_lane_soft_reset(struct intel_encoder *encoder,void chv_phy_pre_pll_enable (struct intel_encoder *encoder);void chv_phy_pre_encoder_enable (struct intel_encoder *encoder);void chv_phy_release_cl2_override (struct intel_encoder *encoder); +void chv_phy_post_pll_disable (struct intel_encoder *encoder);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +1 -29
@@ -2838,35 +2838,7 @@ static void chv_dp_pre_pll_enable(struct intel_encoder *encoder)static void chv_dp_post_pll_disable (struct intel_encoder *encoder) { -struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); -enum pipe pipe =to_intel_crtc (encoder->base.crtc)->pipe; -u32 val; - -mutex_lock (&dev_priv->sb_lock); - -/* disable left/right clock distribution */ -if (pipe !=PIPE_B ) { - val =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW5_CH0); - val &= ~(CHV_BUFLEFTENA1_MASK |CHV_BUFRIGHTENA1_MASK ); -vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW5_CH0, val); - }else { - val =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW1_CH1); - val &= ~(CHV_BUFLEFTENA2_MASK |CHV_BUFRIGHTENA2_MASK ); -vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW1_CH1, val); - } - -mutex_unlock (&dev_priv->sb_lock); - -/* -* Leave the power down bit cleared for at least one -* lane so that chv_powergate_phy_ch() will power -* on something when the channel is otherwise unused. -* When the port is off and the override is removed -* the lanes power down anyway, so otherwise it doesn't -* really matter what the state of power down bits is -* after this. -*/ -chv_phy_powergate_lanes (encoder, false,0x0 ); +chv_phy_post_pll_disable (encoder); }/*
drivers/gpu/drm/i915/intel_dpio_phy.c +33 -0
@@ -336,3 +336,36 @@ void chv_phy_release_cl2_override(struct intel_encoder *encoder) dport->release_cl2_override = false; } } + +void chv_phy_post_pll_disable (struct intel_encoder *encoder) +{ +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +enum pipe pipe =to_intel_crtc (encoder->base.crtc)->pipe; +u32 val; + +mutex_lock (&dev_priv->sb_lock); + +/* disable left/right clock distribution */ +if (pipe !=PIPE_B ) { + val =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW5_CH0); + val &= ~(CHV_BUFLEFTENA1_MASK |CHV_BUFRIGHTENA1_MASK ); +vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW5_CH0, val); + }else { + val =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW1_CH1); + val &= ~(CHV_BUFLEFTENA2_MASK |CHV_BUFRIGHTENA2_MASK ); +vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW1_CH1, val); + } + +mutex_unlock (&dev_priv->sb_lock); + +/* +* Leave the power down bit cleared for at least one +* lane so that chv_powergate_phy_ch() will power +* on something when the channel is otherwise unused. +* When the port is off and the override is removed +* the lanes power down anyway, so otherwise it doesn't +* really matter what the state of power down bits is +* after this. +*/ +chv_phy_powergate_lanes (encoder, false,0x0 ); +}
drivers/gpu/drm/i915/intel_hdmi.c +1 -29
@@ -1675,35 +1675,7 @@ static void chv_hdmi_pre_pll_enable(struct intel_encoder *encoder)static void chv_hdmi_post_pll_disable (struct intel_encoder *encoder) { -struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); -enum pipe pipe =to_intel_crtc (encoder->base.crtc)->pipe; -u32 val; - -mutex_lock (&dev_priv->sb_lock); - -/* disable left/right clock distribution */ -if (pipe !=PIPE_B ) { - val =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW5_CH0); - val &= ~(CHV_BUFLEFTENA1_MASK |CHV_BUFRIGHTENA1_MASK ); -vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW5_CH0, val); - }else { - val =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW1_CH1); - val &= ~(CHV_BUFLEFTENA2_MASK |CHV_BUFRIGHTENA2_MASK ); -vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW1_CH1, val); - } - -mutex_unlock (&dev_priv->sb_lock); - -/* -* Leave the power down bit cleared for at least one -* lane so that chv_powergate_phy_ch() will power -* on something when the channel is otherwise unused. -* When the port is off and the override is removed -* the lanes power down anyway, so otherwise it doesn't -* really matter what the state of power down bits is -* after this. -*/ -chv_phy_powergate_lanes (encoder, false,0x0 ); +chv_phy_post_pll_disable (encoder); }static void vlv_hdmi_post_disable (struct intel_encoder *encoder)
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 7/10 drm/i915: Unduplicate VLV signal level code
In reply to Ander Conselvan de OliveiraThe logic for setting signal levels is used for both HDMI and DP with small variations. But it is similar enough to put behind a function called from the encoders.
v2: Remove unrelated MST changes due to rebase fumble. (Jim Bride)
Fix typo in the commit message. (Jim Bride)
v3: Really fix the typo. (Jim)
--- drivers/gpu/drm/i915/i915_drv.h | 4 ++++ drivers/gpu/drm/i915/intel_dp.c | 20 +++----------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 26 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 14 ++++---------- 4 files changed, 37 insertions(+), 27 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +4 -0
@@ -3588,6 +3588,10 @@ void chv_phy_pre_encoder_enable(struct intel_encoder *encoder);void chv_phy_release_cl2_override (struct intel_encoder *encoder);void chv_phy_post_pll_disable (struct intel_encoder *encoder); +void vlv_set_phy_signal_level (struct intel_encoder *encoder, +u32 demph_reg_value,u32 preemph_reg_value, +u32 uniqtranscale_reg_value,u32 tx3_demph); +int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +3 -17
@@ -2946,16 +2946,10 @@ intel_dp_pre_emphasis_max(struct intel_dp *intel_dp, uint8_t voltage_swing)static uint32_t vlv_signal_levels (struct intel_dp *intel_dp) { -struct drm_device *dev =intel_dp_to_dev (intel_dp); -struct drm_i915_private *dev_priv = dev->dev_private; -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct intel_crtc *intel_crtc = -to_intel_crtc (dport->base.base.crtc); +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base;unsigned long demph_reg_value, preemph_reg_value, uniqtranscale_reg_value;uint8_t train_set = intel_dp->train_set[0 ]; -enum dpio_channel port =vlv_dport_to_channel (dport); -int pipe = intel_crtc->pipe;switch (train_set &DP_TRAIN_PRE_EMPHASIS_MASK ) {case DP_TRAIN_PRE_EMPH_LEVEL_0 :
@@ -3030,16 +3024,8 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp)return 0 ; } -mutex_lock (&dev_priv->sb_lock); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),0x00000000 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW4 (port), demph_reg_value); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW2 (port), - uniqtranscale_reg_value); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW3 (port),0x0C782040 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW11 (port),0x00030000 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW9 (port), preemph_reg_value); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),0x80000000 ); -mutex_unlock (&dev_priv->sb_lock); +vlv_set_phy_signal_level (encoder, demph_reg_value, preemph_reg_value, + uniqtranscale_reg_value,0 );return 0 ; }
drivers/gpu/drm/i915/intel_dpio_phy.c +26 -0
@@ -369,3 +369,29 @@ void chv_phy_post_pll_disable(struct intel_encoder *encoder)*/ chv_phy_powergate_lanes (encoder, false,0x0 ); } + +void vlv_set_phy_signal_level (struct intel_encoder *encoder, +u32 demph_reg_value,u32 preemph_reg_value, +u32 uniqtranscale_reg_value,u32 tx3_demph) +{ +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct intel_crtc *intel_crtc =to_intel_crtc (encoder->base.crtc); +struct intel_digital_port *dport =enc_to_dig_port (&encoder->base); +enum dpio_channel port =vlv_dport_to_channel (dport); +int pipe = intel_crtc->pipe; + +mutex_lock (&dev_priv->sb_lock); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),0x00000000 ); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW4 (port), demph_reg_value); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW2 (port), + uniqtranscale_reg_value); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW3 (port),0x0C782040 ); + +if (tx3_demph) +vlv_dpio_write (dev_priv, pipe,VLV_TX3_DW4 (port), tx3_demph); + +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW11 (port),0x00030000 ); +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW9 (port), preemph_reg_value); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),DPIO_TX_OCALINIT_EN ); +mutex_unlock (&dev_priv->sb_lock); +}
drivers/gpu/drm/i915/intel_hdmi.c +4 -10
@@ -1609,21 +1609,15 @@ static void vlv_hdmi_pre_enable(struct intel_encoder *encoder) val |=0x001000c4 ;vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW8 (port), val); -/* HDMI 1.0V-2dB */ -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),0 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW4 (port),0x2b245f5f ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW2 (port),0x5578b83a ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW3 (port),0x0c782040 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX3_DW4 (port),0x2b247878 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW11 (port),0x00030000 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW9 (port),0x00002000 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),DPIO_TX_OCALINIT_EN ); -/* Program lane clock */ vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW14 (port),0x00760018 );vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW23 (port),0x00400888 );mutex_unlock (&dev_priv->sb_lock); +/* HDMI 1.0V-2dB */ +vlv_set_phy_signal_level (encoder,0x2b245f5f ,0x00002000 ,0x5578b83a , +0x2b247878 ); + intel_hdmi->set_infoframes (&encoder->base, intel_crtc->config->has_hdmi_sink, adjusted_mode);
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 8/10 drm/i915: Unduplicate VLV phy pre pll enabling code
In reply to Ander Conselvan de OliveiraThe code used by the DP and HDMI paths was very similar, so make them share it. Note that this removes the write to signal level registers from the HDMI pre pll enable path, but that's OK since those are set in vlv_hdmi_pre_enable() function.
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 25 +------------------------ drivers/gpu/drm/i915/intel_dpio_phy.c | 28 ++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 28 +--------------------------- 4 files changed, 31 insertions(+), 51 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -3591,6 +3591,7 @@ void chv_phy_post_pll_disable(struct intel_encoder *encoder);void vlv_set_phy_signal_level (struct intel_encoder *encoder,u32 demph_reg_value,u32 preemph_reg_value,u32 uniqtranscale_reg_value,u32 tx3_demph); +void vlv_phy_pre_pll_enable (struct intel_encoder *encoder);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +1 -24
@@ -2791,32 +2791,9 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)static void vlv_dp_pre_pll_enable (struct intel_encoder *encoder) { -struct intel_digital_port *dport =enc_to_dig_port (&encoder->base); -struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; -struct intel_crtc *intel_crtc = -to_intel_crtc (encoder->base.crtc); -enum dpio_channel port =vlv_dport_to_channel (dport); -int pipe = intel_crtc->pipe; -intel_dp_prepare (encoder); -/* Program Tx lane resets to default */ -mutex_lock (&dev_priv->sb_lock); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW0 (port), -DPIO_PCS_TX_LANE2_RESET | -DPIO_PCS_TX_LANE1_RESET ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW1 (port), -DPIO_PCS_CLK_CRI_RXEB_EIOS_EN | -DPIO_PCS_CLK_CRI_RXDIGFILTSG_EN | - (1 <<DPIO_PCS_CLK_DATAWIDTH_SHIFT ) | -DPIO_PCS_CLK_SOFT_RESET ); - -/* Fix up inter-pair skew failure */ -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW12 (port),0x00750f00 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW11 (port),0x00001500 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW14 (port),0x40400000 ); -mutex_unlock (&dev_priv->sb_lock); +vlv_phy_pre_pll_enable (encoder); }static void chv_pre_enable_dp (struct intel_encoder *encoder)
drivers/gpu/drm/i915/intel_dpio_phy.c +28 -0
@@ -395,3 +395,31 @@ void vlv_set_phy_signal_level(struct intel_encoder *encoder,vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),DPIO_TX_OCALINIT_EN );mutex_unlock (&dev_priv->sb_lock); } + +void vlv_phy_pre_pll_enable (struct intel_encoder *encoder) +{ +struct intel_digital_port *dport =enc_to_dig_port (&encoder->base); +struct drm_device *dev = encoder->base.dev; +struct drm_i915_private *dev_priv = dev->dev_private; +struct intel_crtc *intel_crtc = +to_intel_crtc (encoder->base.crtc); +enum dpio_channel port =vlv_dport_to_channel (dport); +int pipe = intel_crtc->pipe; + +/* Program Tx lane resets to default */ +mutex_lock (&dev_priv->sb_lock); +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW0 (port), +DPIO_PCS_TX_LANE2_RESET | +DPIO_PCS_TX_LANE1_RESET ); +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW1 (port), +DPIO_PCS_CLK_CRI_RXEB_EIOS_EN | +DPIO_PCS_CLK_CRI_RXDIGFILTSG_EN | + (1 <<DPIO_PCS_CLK_DATAWIDTH_SHIFT ) | +DPIO_PCS_CLK_SOFT_RESET ); + +/* Fix up inter-pair skew failure */ +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW12 (port),0x00750f00 ); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW11 (port),0x00001500 ); +vlv_dpio_write (dev_priv, pipe,VLV_TX_DW14 (port),0x40400000 ); +mutex_unlock (&dev_priv->sb_lock); +}
drivers/gpu/drm/i915/intel_hdmi.c +1 -27
@@ -1629,35 +1629,9 @@ static void vlv_hdmi_pre_enable(struct intel_encoder *encoder)static void vlv_hdmi_pre_pll_enable (struct intel_encoder *encoder) { -struct intel_digital_port *dport =enc_to_dig_port (&encoder->base); -struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; -struct intel_crtc *intel_crtc = -to_intel_crtc (encoder->base.crtc); -enum dpio_channel port =vlv_dport_to_channel (dport); -int pipe = intel_crtc->pipe; -intel_hdmi_prepare (encoder); -/* Program Tx lane resets to default */ -mutex_lock (&dev_priv->sb_lock); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW0 (port), -DPIO_PCS_TX_LANE2_RESET | -DPIO_PCS_TX_LANE1_RESET ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW1 (port), -DPIO_PCS_CLK_CRI_RXEB_EIOS_EN | -DPIO_PCS_CLK_CRI_RXDIGFILTSG_EN | - (1 <<DPIO_PCS_CLK_DATAWIDTH_SHIFT ) | -DPIO_PCS_CLK_SOFT_RESET ); - -/* Fix up inter-pair skew failure */ -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW12 (port),0x00750f00 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW11 (port),0x00001500 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW14 (port),0x40400000 ); - -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW9 (port),0x00002000 ); -vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),DPIO_TX_OCALINIT_EN ); -mutex_unlock (&dev_priv->sb_lock); +vlv_phy_pre_pll_enable (encoder); }static void chv_hdmi_pre_pll_enable (struct intel_encoder *encoder)
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 9/10 drm/i915: Unduplicate pre encoder enabling phy code
In reply to Ander Conselvan de OliveiraThe phy code in vlv_pre_enable_dp() and vlv_hdmi_pre_enable() is exectly the same, so extract it to intel_dpio_phy.c.
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 24 +----------------------- drivers/gpu/drm/i915/intel_dpio_phy.c | 30 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 19 +------------------ 4 files changed, 33 insertions(+), 41 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -3592,6 +3592,7 @@ void vlv_set_phy_signal_level(struct intel_encoder *encoder, u32 demph_reg_value, u32 preemph_reg_value, u32 uniqtranscale_reg_value, u32 tx3_demph);void vlv_phy_pre_pll_enable (struct intel_encoder *encoder); +void vlv_phy_pre_encoder_enable (struct intel_encoder *encoder);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dp.c +1 -23
@@ -2762,29 +2762,7 @@ static void vlv_init_panel_power_sequencer(struct intel_dp *intel_dp)static void vlv_pre_enable_dp (struct intel_encoder *encoder) { -struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base); -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; -struct intel_crtc *intel_crtc =to_intel_crtc (encoder->base.crtc); -enum dpio_channel port =vlv_dport_to_channel (dport); -int pipe = intel_crtc->pipe; -u32 val; - -mutex_lock (&dev_priv->sb_lock); - - val =vlv_dpio_read (dev_priv, pipe,VLV_PCS01_DW8 (port)); - val =0 ; -if (pipe) - val |= (1 <<21 ); -else - val &= ~(1 <<21 ); - val |=0x001000c4 ; -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW8 (port), val); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW14 (port),0x00760018 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW23 (port),0x00400888 ); - -mutex_unlock (&dev_priv->sb_lock); +vlv_phy_pre_encoder_enable (encoder);intel_enable_dp (encoder); }
drivers/gpu/drm/i915/intel_dpio_phy.c +30 -0
@@ -423,3 +423,33 @@ void vlv_phy_pre_pll_enable(struct intel_encoder *encoder)vlv_dpio_write (dev_priv, pipe,VLV_TX_DW14 (port),0x40400000 );mutex_unlock (&dev_priv->sb_lock); } + +void vlv_phy_pre_encoder_enable (struct intel_encoder *encoder) +{ +struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base); +struct intel_digital_port *dport =dp_to_dig_port (intel_dp); +struct drm_device *dev = encoder->base.dev; +struct drm_i915_private *dev_priv = dev->dev_private; +struct intel_crtc *intel_crtc =to_intel_crtc (encoder->base.crtc); +enum dpio_channel port =vlv_dport_to_channel (dport); +int pipe = intel_crtc->pipe; +u32 val; + +mutex_lock (&dev_priv->sb_lock); + +/* Enable clock channels for this port */ + val =vlv_dpio_read (dev_priv, pipe,VLV_PCS01_DW8 (port)); + val =0 ; +if (pipe) + val |= (1 <<21 ); +else + val &= ~(1 <<21 ); + val |=0x001000c4 ; +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW8 (port), val); + +/* Program lane clock */ +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW14 (port),0x00760018 ); +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW23 (port),0x00400888 ); + +mutex_unlock (&dev_priv->sb_lock); +}
drivers/gpu/drm/i915/intel_hdmi.c +1 -18
@@ -1594,25 +1594,8 @@ static void vlv_hdmi_pre_enable(struct intel_encoder *encoder)struct intel_crtc *intel_crtc =to_intel_crtc (encoder->base.crtc);const struct drm_display_mode *adjusted_mode = &intel_crtc->config->base.adjusted_mode; -enum dpio_channel port =vlv_dport_to_channel (dport); -int pipe = intel_crtc->pipe; -u32 val; - -/* Enable clock channels for this port */ -mutex_lock (&dev_priv->sb_lock); - val =vlv_dpio_read (dev_priv, pipe,VLV_PCS01_DW8 (port)); - val =0 ; -if (pipe) - val |= (1 <<21 ); -else - val &= ~(1 <<21 ); - val |=0x001000c4 ; -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW8 (port), val); -/* Program lane clock */ -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW14 (port),0x00760018 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW23 (port),0x00400888 ); -mutex_unlock (&dev_priv->sb_lock); +vlv_phy_pre_encoder_enable (encoder);/* HDMI 1.0V-2dB */ vlv_set_phy_signal_level(encoder, 0x2b245f5f, 0x00002000, 0x5578b83a,
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 10/10 drm/i915: Move VLV HDMI lane reset work around logic to intel_dpio_phy.c
In reply to Ander Conselvan de OliveiraThis moves the last phy specific code from the encoders to the phy specific file.
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_dpio_phy.c | 15 +++++++++++++++ drivers/gpu/drm/i915/intel_hdmi.c | 12 +----------- 3 files changed, 17 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -3593,6 +3593,7 @@ void vlv_set_phy_signal_level(struct intel_encoder *encoder, u32 uniqtranscale_reg_value, u32 tx3_demph);void vlv_phy_pre_pll_enable (struct intel_encoder *encoder);void vlv_phy_pre_encoder_enable (struct intel_encoder *encoder); +void vlv_phy_reset_lanes (struct intel_encoder *encoder);int intel_gpu_freq (struct drm_i915_private *dev_priv,int val);int intel_freq_opcode (struct drm_i915_private *dev_priv,int val);
drivers/gpu/drm/i915/intel_dpio_phy.c +15 -0
@@ -453,3 +453,18 @@ void vlv_phy_pre_encoder_enable(struct intel_encoder *encoder)mutex_unlock (&dev_priv->sb_lock); } + +void vlv_phy_reset_lanes (struct intel_encoder *encoder) +{ +struct intel_digital_port *dport =enc_to_dig_port (&encoder->base); +struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; +struct intel_crtc *intel_crtc = +to_intel_crtc (encoder->base.crtc); +enum dpio_channel port =vlv_dport_to_channel (dport); +int pipe = intel_crtc->pipe; + +mutex_lock (&dev_priv->sb_lock); +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW0 (port),0x00000000 ); +vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW1 (port),0x00e00060 ); +mutex_unlock (&dev_priv->sb_lock); +}
drivers/gpu/drm/i915/intel_hdmi.c +1 -11
@@ -1631,18 +1631,8 @@ static void chv_hdmi_post_pll_disable(struct intel_encoder *encoder)static void vlv_hdmi_post_disable (struct intel_encoder *encoder) { -struct intel_digital_port *dport =enc_to_dig_port (&encoder->base); -struct drm_i915_private *dev_priv = encoder->base.dev->dev_private; -struct intel_crtc *intel_crtc = -to_intel_crtc (encoder->base.crtc); -enum dpio_channel port =vlv_dport_to_channel (dport); -int pipe = intel_crtc->pipe; -/* Reset lanes to avoid HDMI flicker (VLV w/a) */ -mutex_lock (&dev_priv->sb_lock); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW0 (port),0x00000000 ); -vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW1 (port),0x00e00060 ); -mutex_unlock (&dev_priv->sb_lock); +vlv_phy_reset_lanes (encoder); }static void chv_hdmi_post_disable (struct intel_encoder *encoder)
Signature · 6 lines
2.4.11 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for Unduplicate CHV phy code (rev5)
In reply to Ander Conselvan de Oliveira== Series Details ==
== Series Details ==
Series: Unduplicate CHV phy code (rev5)
URL : https://patchwork.freedesktop.org/series/5463/
State : failure
== Summary ==
Series 5463v5 Unduplicate CHV phy code
http://patchwork.freedesktop.org/api/1.0/series/5463/revisions/5/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (snb-x220t)
Test gem_exec_suspend:
Subgroup basic-s3:
fail -> PASS (snb-x220t)
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (snb-dellxps)
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (hsw-gt2)bdw-nuci7 total:200 pass:188 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:200 pass:175 dwarn:0 dfail:0 fail:0 skip:25 bsw-nuc-2 total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 byt-nuc total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 hsw-brixbox total:200 pass:174 dwarn:0 dfail:0 fail:0 skip:26 hsw-gt2 total:199 pass:176 dwarn:0 dfail:0 fail:1 skip:21 ilk-hp8440p total:200 pass:139 dwarn:0 dfail:0 fail:0 skip:61 ivb-t430s total:200 pass:169 dwarn:0 dfail:0 fail:0 skip:31 skl-i7k-2 total:200 pass:173 dwarn:0 dfail:0 fail:0 skip:27 skl-nuci5 total:200 pass:189 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:200 pass:157 dwarn:1 dfail:0 fail:0 skip:42 snb-x220t total:200 pass:158 dwarn:0 dfail:0 fail:1 skip:41
Results at /archive/results/CI_IGT_test/Patchwork_2090/
4fa405ab5848b76c8568c7fb771d389a6695108c drm-intel-nightly: 2016y-04m-27d-10h-47m-35s UTC integration manifest 9e163c0 drm/i915: Move VLV HDMI lane reset work around logic to intel_dpio_phy.c
b7b843d drm/i915: Unduplicate pre encoder enabling phy code
4165303 drm/i915: Unduplicate VLV phy pre pll enabling code
7241e40 drm/i915: Unduplicate VLV signal level code
1879a24 drm/i915: Unduplicate CHV encoders' post pll disable code
3b54e74 drm/i915: Unduplicate CHV pre-encoder enabling phy logic
66e88ec drm/i915: Unduplicate CHV phy-releated pre pll enabling code
8a2b013 drm/i915: Unduplicate chv_data_lane_soft_reset()
4a6d52d drm/i915: Unduplicate CHV signal level code
5a20188 drm/i915: Set crtc_state->lane_count for HDMI
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for Unduplicate CHV phy code (rev5)
Quoted 11 lines · Patchwork
== Series Details ==
Series: Unduplicate CHV phy code (rev5)
URL : https://patchwork.freedesktop.org/series/5463/
State : failure== Summary ==
Series 5463v5 Unduplicate CHV phy code
http://patchwork.freedesktop.org/api/1.0/series/5463/revisions/5/mbox/
Quoted 8 lines
Test
drv_module_reload_basic:dmesg-warn -> PASS (snb-x220t) Test gem_exec_suspend: Subgroup basic-s3: fail -> PASS (snb-x220t) Test kms_pipe_crc_basic: Subgroup hang-read-crc-pipe-a: pass -> DMESG-WARN (snb-dellxps)
[ 303.915830] ------------[ cut here ]------------ [ 303.915859] WARNING: CPU: 5 PID: 6657 at drivers/gpu/drm/i915/intel_display.c:13529 intel_atomic_commit+0x1271/0x1400 [i915] [ 303.915861] pipe A vblank wait timed out
https://bugs.freedesktop.org/show_bug.cgi?id=95125
Quoted 2 lines
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (hsw-gt2)dmesg ends with
[ 505.669959] kms_pipe_crc_basic: starting subtest suspend-read-crc-pipe-A
Seems very unlikely this would be caused by this series. The only code that is run on hsw machines is setting the lane count field in crtc_state, but that is not used anywhere.
Are there any know issues with this machine?
Ander
Quoted 16 lines
bdw-nuci7 total:200 pass:188 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:200 pass:175 dwarn:0 dfail:0 fail:0 skip:25 bsw-nuc-2 total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 byt-nuc total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 hsw-brixbox total:200 pass:174 dwarn:0 dfail:0 fail:0 skip:26 hsw-gt2 total:199 pass:176 dwarn:0 dfail:0 fail:1 skip:21 ilk-hp8440p total:200 pass:139 dwarn:0 dfail:0 fail:0 skip:61 ivb-t430s total:200 pass:169 dwarn:0 dfail:0 fail:0 skip:31 skl-i7k-2 total:200 pass:173 dwarn:0 dfail:0 fail:0 skip:27 skl-nuci5 total:200 pass:189 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:200 pass:157 dwarn:1 dfail:0 fail:0 skip:42 snb-x220t total:200 pass:158 dwarn:0 dfail:0 fail:1 skip:41Results at /archive/results/CI_IGT_test/Patchwork_2090/
Quoted 14 lines
4fa405ab5848b76c8568c7fb771d389a6695108cdrm-intel-nightly: 2016y-04m-27d-10h -47m-35s UTC integration manifest
9e163c0 drm/i915: Move VLV HDMI lane reset work around logic tointel_dpio_phy.c
b7b843d drm/i915: Unduplicate pre encoder enabling phy code 4165303 drm/i915: Unduplicate VLV phy pre pll enabling code 7241e40 drm/i915: Unduplicate VLV signal level code
1879a24 drm/i915: Unduplicate CHV encoders' post pll disable code 3b54e74 drm/i915: Unduplicate CHV pre-encoder enabling phy logic 66e88ec drm/i915: Unduplicate CHV phy-releated pre pll enabling code 8a2b013 drm/i915: Unduplicatechv_data_lane_soft_reset()
4a6d52d drm/i915: Unduplicate CHV signal level code
5a20188 drm/i915: Setcrtc_state->lane_countfor HDMI
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for Unduplicate CHV phy code (rev5)
Hello,
Quoted 5 lines · On Wednesday 27 April 2016 16:36:13 Ander Conselvan De Oliveira wrote:
Quoted 2 lines
Subgroup suspend-read-crc-pipe-a: pass -> INCOMPLETE (hsw-gt2)dmesg ends with
Quoted 7 lines
[ 505.669959] kms_pipe_crc_basic: starting subtest suspend-read-crc-pipe-ASeems very unlikely this would be caused by this series. The only code that is run on hsw machines is setting the lane count field in
crtc_state, but that is not used anywhere.Are there any know issues with this machine?
There is no known issues with this hardware itself. There is one known issue with HSW and drm-intel kernel, which has taken a while to figure out. I think it still exists in the baseline kernel where patch is applied.
(It's hard to replicate with IGT, but newest Mesa seems to hit it quite regularly).
Regards,
Tomi
Quoted 32 lines
Ander
Quoted 28 lines
bdw-nuci7 total:200 pass:188 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:200 pass:175 dwarn:0 dfail:0 fail:0 skip:25 bsw-nuc-2 total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 byt-nuc total:199 pass:158 dwarn:0 dfail:0 fail:0 skip:41 hsw-brixbox total:200 pass:174 dwarn:0 dfail:0 fail:0 skip:26 hsw-gt2 total:199 pass:176 dwarn:0 dfail:0 fail:1 skip:21 ilk-hp8440p total:200 pass:139 dwarn:0 dfail:0 fail:0 skip:61 ivb-t430s total:200 pass:169 dwarn:0 dfail:0 fail:0 skip:31 skl-i7k-2 total:200 pass:173 dwarn:0 dfail:0 fail:0 skip:27 skl-nuci5 total:200 pass:189 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:200 pass:157 dwarn:1 dfail:0 fail:0 skip:42 snb-x220t total:200 pass:158 dwarn:0 dfail:0 fail:1 skip:41Results at /archive/results/CI_IGT_test/Patchwork_2090/
4fa405ab5848b76c8568c7fb771d389a6695108cdrm-intel-nightly:
2016y-04m-27d-10h -47m-35s UTC integration manifest 9e163c0 drm/i915: Move VLV HDMI lane reset work around logic tointel_dpio_phy.c
b7b843d drm/i915: Unduplicate pre encoder enabling phy code 4165303 drm/i915: Unduplicate VLV phy pre pll enabling code 7241e40 drm/i915: Unduplicate VLV signal level code 1879a24 drm/i915: Unduplicate CHV encoders' post pll disable code 3b54e74 drm/i915: Unduplicate CHV pre-encoder enabling phy logic 66e88ec drm/i915: Unduplicate CHV phy-releated pre pll enabling code 8a2b013 drm/i915: Unduplicatechv_data_lane_soft_reset()4a6d52d drm/i915: Unduplicate CHV signal level code 5a20188 drm/i915: Setcrtc_state->lane_countfor HDMI
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for Unduplicate CHV phy code (rev5)
Quoted 14 lines · Tomi Sarvela
Hello,
Quoted 11 lines · On Wednesday 27 April 2016 16:36:13 Ander Conselvan De Oliveira wrote:
Quoted 2 lines
Subgroup suspend-read-crc-pipe-a: pass -> INCOMPLETE (hsw-gt2)dmesg ends with
[ 505.669959] kms_pipe_crc_basic: starting subtest suspend-read-crc-pipe-ASeems very unlikely this would be caused by this series. The only code that is run on hsw machines is setting the lane count field in
crtc_state, but that is not used anywhere.
Quoted 8 lines
Quoted 1 line
Are there any know issues with this machine?
There is no known issues with this hardware itself. There is one known issue with HSW and drm-intel kernel, which has taken a while to figure out. I think it still exists in the baseline kernel where patch is applied.
(It's hard to replicate with IGT, but newest Mesa seems to hit it quite regularly).
Patches pushed to dinq.
Thanks,
Ander
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx