ixgbevf: Remove unused parameter
Subsystems (2)
Nguyen
PATCH 1/1 ixgbevf: Remove unused parameter
ixgbevf_update_xcast_mode() is not using the netdev parameter; removing it since it's unnecessary.
--- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- drivers/net/ethernet/intel/ixgbevf/vf.c | 4 +--- drivers/net/ethernet/intel/ixgbevf/vf.h | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +1 -1
@@ -1908,7 +1908,7 @@ static void ixgbevf_set_rx_mode(struct net_device *netdev)spin_lock_bh (&adapter->mbx_lock); - hw->mac.ops.update_xcast_mode (hw, netdev, xcast_mode); + hw->mac.ops.update_xcast_mode (hw, xcast_mode);/* reprogram multicast list */ hw->mac.ops.update_mc_addr_list(hw, netdev); diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
index 4d613a4..9511da0 100644
drivers/net/ethernet/intel/ixgbevf/vf.c +2 -3
@@ -475,13 +475,11 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,/** * ixgbevf_update_xcast_mode - Update Multicast mode * @hw: pointer to the HW structure -* @netdev: pointer to net device structure * @xcast_mode: new multicast mode * * Updates the Multicast Mode of VF. **/ -static s32 ixgbevf_update_xcast_mode (struct ixgbe_hw *hw, -struct net_device *netdev,int xcast_mode) +static s32 ixgbevf_update_xcast_mode (struct ixgbe_hw *hw,int +xcast_mode) {struct ixgbe_mbx_info *mbx = &hw->mbx;
u32 msgbuf[2];
drivers/net/ethernet/intel/ixgbevf/vf.h +1 -1
@@ -63,7 +63,7 @@ struct ixgbe_mac_operations {s32 (*set_uc_addr)(struct ixgbe_hw *,u32 ,u8 *);s32 (*init_rx_addrs)(struct ixgbe_hw *);s32 (*update_mc_addr_list)(struct ixgbe_hw *,struct net_device *); -s32 (*update_xcast_mode)(struct ixgbe_hw *,struct net_device *,int ); +s32 (*update_xcast_mode)(struct ixgbe_hw *,int );s32 (*enable_mc)(struct ixgbe_hw *);s32 (*disable_mc)(struct ixgbe_hw *);s32 (*clear_vfta)(struct ixgbe_hw *);
PATCH 1/1 ixgbevf: Remove unused parameter
Quoted 9 lines · Anthony L
ixgbevf_update_xcast_mode()is not using the netdev parameter; removing it since it's unnecessary.Signed-off-by Tony Nguyen <[email protected]>---
?drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- ?drivers/net/ethernet/intel/ixgbevf/vf.c?????????? | 4 +--- ?drivers/net/ethernet/intel/ixgbevf/vf.h?????????? | 2 +-?3 files changed, 3 insertions(+), 5 deletions(-)
2 issues with this patch, first it was corrupted by whatever means you used to send this patch. ?Second this patch fails to compile (after I had to apply it by hand) because it was not generated against my lastest dev-queue branch.
There are only three things I ask when generating kernel patches:
1- always use my dev-queue branch to generate kernel patches against
our Intel wired LAN drivers
2- run checkpatch.pl against your patch and fix the reported errors and
possibly warnings
3- Compile test your patch before sending it off to intel-wired-lan at lis ts.osuosl.org?mailing list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160427/ba6a98c4/attachment.asc>
PATCH 1/1 ixgbevf: Remove unused parameter
Quoted 17 lines · Jeff Kirsher
Quoted 9 lines · Anthony L
ixgbevf_update_xcast_mode()is not using the netdev parameter; removing it since it's unnecessary.
?Signed-off-by Tony Nguyen <[email protected]>---
?drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- ?drivers/net/ethernet/intel/ixgbevf/vf.c?????????? | 4 +--- ?drivers/net/ethernet/intel/ixgbevf/vf.h?????????? | 2 +-?3 files changed, 3 insertions(+), 5 deletions(-)
2 issues with this patch, first it was corrupted by whatever means you
used to send this patch. ?Second this patch fails to compile (after I had to apply it by hand) because it was not generated against my lastest dev-queue branch.
Quoted 9 lines
There are only three things I ask when generating kernel patches:
1- always use my dev-queue branch to generate kernel patches against our Intel wired LAN drivers
2- run checkpatch.pl against your patch and fix the reported errors and
possibly warnings
3- Compile test your patch before sending it off to intel-wired-lan at l is
ts.osuosl.org?mailing list
Oh forgot to mention, dropping this patch for the v2 I created for Tony
:-(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160427/26b19dc7/attachment.asc>