Skip to contentSkip to conversation

Patch "mtd: nand: pxa3xx_nand: fix dmaengine initialization" has been added to the 4.5-stable tree

PATCH [email protected] 1 participant 1 message Apr 28, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: nand: pxa3xx_nand: fix dmaengine initialization

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-nand-pxa3xx_nand-fix-dmaengine-initialization.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9097103f06332d099c5ab06d1e7f22f4bcaca6e2 Mon Sep 17 00:00:00 2001

From: Robert Jarzmik <[email protected]>
Date: Fri, 12 Feb 2016 23:29:04 +0100
Subject: mtd: nand: pxa3xx_nand: fix dmaengine initialization

From: Robert Jarzmik <[email protected]>

commit 9097103f06332d099c5ab06d1e7f22f4bcaca6e2 upstream.

When the driver is initialized in a pure device-tree platform, the driver's probe fails allocating the dma channel :

[  525.624435] pxa3xx-nand 43100000.nand: no resource defined for data DMA
[  525.632088] pxa3xx-nand 43100000.nand: alloc nand resource failed

The reason is that the DMA IO resource is not acquired through platform resources but by OF bindings.

Fix this by ensuring that DMA IO resources are only queried in the non device-tree case.

Fixes 8f5ba31aa565 ("mtd: nand: pxa3xx-nand: switch to dmaengine")
---
 drivers/mtd/nand/pxa3xx_nand.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/pxa3xx_nand.c +1 -1
@@ -1738,7 +1738,7 @@ static int alloc_nand_resource(struct pl
 	if (ret < 0)
 		return ret;
 
-	if (use_dma) {
+	if (!np && use_dma) {
 		r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
 		if (r == NULL) {
 			dev_err(&pdev->dev,

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/dmaengine-pxa_dma-fix-the-maximum-requestor-line.patch queue-4.5/mtd-nand-pxa3xx_nand-fix-dmaengine-initialization.patch