Skip to contentSkip to conversation

ASoC: rt5651: remove unexisting widget

PATCH Superseded Bard Liao 2 participants 3 messages Apr 28, 2016

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bard Liao

author
#0 lore raw

PATCH 1/1 ASoC: rt5651: remove unexisting widget

IN Muxes are not existing on rt5651.

---
 sound/soc/codecs/rt5651.c | 5 -----
 1 file changed, 5 deletions(-)
sound/soc/codecs/rt5651.c +0 -5
index 7a61970..b812c06 100644
@@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = {
 			 RT5651_PWR_IN2_L_BIT, 0, NULL, 0),
 	SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL,
 			 RT5651_PWR_IN2_R_BIT, 0, NULL, 0),
-	/* IN Mux */
-	SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux),
-	SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux),
-	SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux),
-	SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux),
 	/* REC Mixer */
 	SND_SOC_DAPM_MIXER("RECMIXL", RT5651_PWR_MIXER, RT5651_PWR_RM_L_BIT, 0,
 			   rt5651_rec_l_mix, ARRAY_SIZE(rt5651_rec_l_mix)),
Signature · 1 line
1.8.1.1.439.g50a6b54
#1 lore raw
Quoted 12 lines · Bard Liao

IN Muxes are not existing on rt5651.

---
 sound/soc/codecs/rt5651.c | 5 -----
 1 file changed, 5 deletions(-)
sound/soc/codecs/rt5651.c +0 -0
index 7a61970..b812c06 100644

sound/soc/codecs/rt5651.c static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = { · line 962

Quoted 8 lines
sound/soc/codecs/rt5651.c +0 -5
@@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = {
 			 RT5651_PWR_IN2_L_BIT, 0, NULL, 0),
 	SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL,
 			 RT5651_PWR_IN2_R_BIT, 0, NULL, 0),
-	/* IN Mux */
-	SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux),
-	SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux),
-	SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux),
-	SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux),

What is with the rt5651_in*_mux controls, those are unused now and can be removed as well, aren't they?

author
#2 lore raw
Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +0 -2
-	/* IN Mux */
-	SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0,

&rt5651_inl1_mux),

Review

Quoted 1 line
(quoted diff) +0 -1
-	SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0,

&rt5651_inr1_mux),

Quoted 7 lines

Review

Quoted 1 line
(quoted diff) +0 -1
-	SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0,

&rt5651_inl2_mux),

Review

Quoted 1 line
(quoted diff) +0 -1
-	SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0,

&rt5651_inr2_mux),

What is with the rt5651_in*_mux controls, those are unused now and can be removed as well, aren't they?

Thanks for the reminder. I will send v2 soon.

Quoted 3 lines

------Please consider the environment before printing this e-mail.