spi: st-ssc4: Allow compile test build
PATCH 1/2 spi: st-ssc4: Allow compile test build
There is no build dependency for this driver, so enable COMPILE_TEST to get better build coverage.
--- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
@@ -581,7 +581,7 @@ config SPI_SIRF config SPI_ST_SSC4 tristate "STMicroelectronics SPI SSC-based driver" - depends on ARCH_STI + depends on ARCH_STI || COMPILE_TEST help STMicroelectronics SoCs support for SPI. If you say yes to this option, support will be included for the SSC driven SPI.
Signature · 6 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 spi: st-ssc4: Fix missing spi_master_put in spi_st_probe error paths
--- drivers/spi/spi-st-ssc4.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/spi/spi-st-ssc4.c +5 -3
@@ -345,12 +345,13 @@ static int spi_st_probe(struct platform_device *pdev) spi_st->clk =devm_clk_get (&pdev->dev,"ssc" );if (IS_ERR (spi_st->clk)) {dev_err (&pdev->dev,"Unable to request clock\n" ); -return PTR_ERR (spi_st->clk); + ret =PTR_ERR (spi_st->clk); + goto put_master; } ret =spi_st_clk_enable (spi_st);if (ret) -return ret; + goto put_master;init_completion (&spi_st->done);
@@ -408,7 +409,8 @@ static int spi_st_probe(struct platform_device *pdev) clk_disable:spi_st_clk_disable (spi_st); - +put_master: +spi_master_put (master);return ret; }
Signature · 6 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Applied "spi: st-ssc4: Fix missing spi_master_put in spi_st_probe error paths" to the spi tree
The patch
spi: st-ssc4: Fix missing spi_master_put in spi_st_probe error paths
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
1051550e9d2d3550e7c17cd563b908638833979dMon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Fri, 29 Apr 2016 13:39:38 +0800
Subject: [PATCH] spi: st-ssc4: Fix missing spi_master_put in spi_st_probe
error paths
--- drivers/spi/spi-st-ssc4.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/spi/spi-st-ssc4.c +5 -3
@@ -345,12 +345,13 @@ static int spi_st_probe(struct platform_device *pdev) spi_st->clk =devm_clk_get (&pdev->dev,"ssc" );if (IS_ERR (spi_st->clk)) {dev_err (&pdev->dev,"Unable to request clock\n" ); -return PTR_ERR (spi_st->clk); + ret =PTR_ERR (spi_st->clk); + goto put_master; } ret =spi_st_clk_enable (spi_st);if (ret) -return ret; + goto put_master;init_completion (&spi_st->done);
@@ -408,7 +409,8 @@ static int spi_st_probe(struct platform_device *pdev) clk_disable:spi_st_clk_disable (spi_st); - +put_master: +spi_master_put (master);return ret; }
Signature · 6 lines
2.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied "spi: st-ssc4: Allow compile test build" to the spi tree
In reply to a message not in the archiveThe patch
spi: st-ssc4: Allow compile test build
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
83fefd2d5bec94de765305d44633c42371360a2aMon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Fri, 29 Apr 2016 13:38:41 +0800
Subject: [PATCH] spi: st-ssc4: Allow compile test build
There is no build dependency for this driver, so enable COMPILE_TEST to get better build coverage.
--- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
@@ -569,7 +569,7 @@ config SPI_SIRF config SPI_ST_SSC4 tristate "STMicroelectronics SPI SSC-based driver" - depends on ARCH_STI + depends on ARCH_STI || COMPILE_TEST help STMicroelectronics SoCs support for SPI. If you say yes to this option, support will be included for the SSC driven SPI.
Signature · 6 lines
2.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html