Skip to contentSkip to conversation

tinymembench: update to version 0.4.0 plus bux fixes

PATCH Superseded Derek Straka 2 participants 3 messages Apr 29, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tinymembench: update to version 0.4.0 plus bux fixes

Removed ARM_INSTRUCTION_SET since it builds on qemuarm and qemuarm64 without issues Also tested the build on qemuppc and qemux86-64

---
 meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +2 -10
index 9898a70..a675bda 100644
@@ -6,9 +6,9 @@ HOMEPAGE = "https://github.com/ssvb/tinymembench/wiki"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://main.c;endline=22;md5=879b9bbb60851454885b5fa47eb6b345"
 
-PV = "0.3.9+git${SRCPV}"
+PV = "0.4.0+git${SRCPV}"
 
-SRCREV = "95e68477588d41187b2d2e52ecf6be0e7eb06b8d"
+SRCREV = "2c789849709d837b4bd114c11ed2d9bdc65afbc6"
 SRC_URI = "git://github.com/ssvb/tinymembench.git"
 
 S = "${WORKDIR}/git"
@@ -17,11 +17,3 @@ do_install() {
     install -d ${D}${bindir}
     install -m755 tinymembench ${D}${bindir}/
 }
-
-# Fails to build with thumb-1 (qemuarm)
-#| {standard input}: Assembler messages:
-#| {standard input}:66: Error: instruction not supported in Thumb16 mode -- `subs r1,r1,#16'
-#| {standard input}:69: Error: instruction not supported in Thumb16 mode -- `subs r1,r1,#16'
-#| {standard input}:82: Error: selected processor does not support Thumb mode `mla r3,r4,r3,r5'
-#| {standard input}:82: Error: unshifted register required -- `and r8,r7,r3,lsr#16'
-ARM_INSTRUCTION_SET = "arm"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Derek Straka

Removed ARM_INSTRUCTION_SET since it builds on qemuarm and qemuarm64 without issues Also tested the build on qemuppc and qemux86-64

For test, you need to set ARM_INSTRUCTION_SET = “thumb” in this recipe and see if that works for qemuarm if that does then it can be removed.

Quoted 41 lines

---
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb | 12 ++----------

1 file changed, 2 insertions(+), 10 deletions(-)
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -0
index 9898a70..a675bda 100644
@@ -6,9 +6,9 @@ HOMEPAGE = "https://github.com/ssvb/tinymembench/wiki"

LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://main.c;endline=22;md5=879b9bbb60851454885b5fa47eb6b345"

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +2 -2
-PV = "0.3.9+git${SRCPV}"
+PV = "0.4.0+git${SRCPV}"
 
-SRCREV = "95e68477588d41187b2d2e52ecf6be0e7eb06b8d"
+SRCREV = "2c789849709d837b4bd114c11ed2d9bdc65afbc6"

SRC_URI = "git://github.com/ssvb/tinymembench.git"

S = "${WORKDIR}/git"

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -9
@@ -17,11 +17,3 @@ do_install() {
    install -d ${D}${bindir}
    install -m755 tinymembench ${D}${bindir}/
 }
-
-# Fails to build with thumb-1 (qemuarm)
-#| {standard input}: Assembler messages:
-#| {standard input}:66: Error: instruction not supported in Thumb16 mode -- `subs r1,r1,#16'
-#| {standard input}:69: Error: instruction not supported in Thumb16 mode -- `subs r1,r1,#16'
-#| {standard input}:82: Error: selected processor does not support Thumb mode `mla r3,r4,r3,r5'
-#| {standard input}:82: Error: unshifted register required -- `and r8,r7,r3,lsr#16'
-ARM_INSTRUCTION_SET = "arm"
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

Ah. That makes more sense why ARM_INSTRUCTION_SET is there. It still fails to build with thumb, so I reverted that portion of the patch. Thanks!

Quoted 62 lines · Khem Raj
Quoted 4 lines · Derek Straka

Removed ARM_INSTRUCTION_SET since it builds on qemuarm and qemuarm64

without issues

Quoted 1 line

Also tested the build on qemuppc and qemux86-64

For test, you need to set ARM_INSTRUCTION_SET = “thumb” in this recipe and see if that works for qemuarm
if that does then it can be removed.

Quoted 3 lines

---
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb | 12

++----------

Review

Quoted 3 lines
1 file changed, 2 insertions(+), 10 deletions(-)
(quoted diff) +0 -0

b/meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb

Quoted 6 lines

index 9898a70..a675bda 100644

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -0
@@ -6,9 +6,9 @@ HOMEPAGE = "https://github.com/ssvb/tinymembench/wiki"

LICENSE = "MIT"
LIC_FILES_CHKSUM =

"file://main.c;endline=22;md5=879b9bbb60851454885b5fa47eb6b345"

Quoted 10 lines
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +2 -2
-PV = "0.3.9+git${SRCPV}"
+PV = "0.4.0+git${SRCPV}"
 
-SRCREV = "95e68477588d41187b2d2e52ecf6be0e7eb06b8d"
+SRCREV = "2c789849709d837b4bd114c11ed2d9bdc65afbc6"

SRC_URI = "git://github.com/ssvb/tinymembench.git"

S = "${WORKDIR}/git"

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb do_install() { · line 23

Quoted 7 lines
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -4
@@ -17,11 +17,3 @@ do_install() {
    install -d ${D}${bindir}
    install -m755 tinymembench ${D}${bindir}/
 }
-
-# Fails to build with thumb-1 (qemuarm)
-#| {standard input}: Assembler messages:
-#| {standard input}:66: Error: instruction not supported in Thumb16

mode -- `subs r1,r1,#16'

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb do_install() { · line 24

Quoted 1 line
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -1
-#| {standard input}:69: Error: instruction not supported in Thumb16

mode -- `subs r1,r1,#16'

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb do_install() { · line 25

Quoted 1 line
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -1
-#| {standard input}:82: Error: selected processor does not support

Thumb mode `mla r3,r4,r3,r5'

meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb do_install() { · line 26

Quoted 1 line
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -1
-#| {standard input}:82: Error: unshifted register required -- `and

r8,r7,r3,lsr#16'

Quoted 9 lines
meta-oe/recipes-benchmark/tinymembench/tinymembench_git.bb +0 -2
-ARM_INSTRUCTION_SET = "arm"
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel