Skip to contentSkip to conversation

FAILED: patch "[PATCH] IB/core: Fix oops in ib_cache_gid_set_default_gid" failed to apply to 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From f4e7de63ab273b6a5e35c82eb4fc6363c855ddd4 Mon Sep 17 00:00:00 2001

From: Doug Ledford <[email protected]>
Date: Fri, 22 Apr 2016 20:14:58 -0400
Subject: [PATCH] IB/core: Fix oops in ib_cache_gid_set_default_gid

When we fail to find the default gid index, we can't continue processing in this routine or else we will pass a negative index to later routines resulting in invalid memory access attempts and a kernel oops.

Fixes 03db3a2d81e6 (IB/core: Add RoCE GID table management)
drivers/infiniband/core/cache.c +2 -1
index cb00d59da456..c2e257d97eff 100644
@@ -691,7 +691,8 @@ void ib_cache_gid_set_default_gid(struct ib_device *ib_dev, u8 port,
 			      NULL);
 
 		/* Coudn't find default GID location */
-		WARN_ON(ix < 0);
+		if (WARN_ON(ix < 0))
+			goto release;
 
 		zattr_type.gid_type = gid_type;