Patch "misc: mic/scif: fix wrap around tests" has been added to the 4.5-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
misc: mic/scif: fix wrap around tests
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
misc-mic-scif-fix-wrap-around-tests.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7b64dbf849abdd7e769820e25120758f956a7f13Mon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Mon, 19 Oct 2015 14:19:01 +0300
Subject: misc: mic/scif: fix wrap around tests
From: Dan Carpenter <[email protected]>
commit 7b64dbf849abdd7e769820e25120758f956a7f13 upstream.
Signed integer overflow is undefined. Also I added a check for "(offset < 0)" in scif_unregister() because that makes it match the other conditions and because I didn't want to subtract a negative.
--- drivers/misc/mic/scif/scif_rma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/misc/mic/scif/scif_rma.c +4 -3
@@ -1511,7 +1511,7 @@ off_t scif_register_pinned_pages(scif_epif ((map_flags &SCIF_MAP_FIXED ) && ((ALIGN (offset,PAGE_SIZE ) != offset) || (offset <0 ) || - (offset + (off_t )len < offset))) + (len >LONG_MAX - offset)))return -EINVAL ;might_sleep ();
@@ -1614,7 +1614,7 @@ off_t scif_register(scif_epd_t epd, voidif ((map_flags &SCIF_MAP_FIXED ) && ((ALIGN (offset,PAGE_SIZE ) != offset) || (offset <0 ) || - (offset + (off_t )len < offset))) + (len >LONG_MAX - offset)))return -EINVAL ;/* Unsupported protection requested */
@@ -1732,7 +1732,8 @@ scif_unregister(scif_epd_t epd, off_t of/* Offset is not page aligned or offset+len wraps around */ if ((ALIGN (offset,PAGE_SIZE ) != offset) || - (offset + (off_t )len < offset)) + (offset <0 ) || + (len >LONG_MAX - offset))return -EINVAL ; err =scif_verify_epd (ep);
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/misc-mic-scif-fix-wrap-around-tests.patch queue-4.5/drm-amdkfd-uninitialized-variable-in-dbgdev_wave_control_set_registers.patch queue-4.5/rtc-ds1685-passing-bogus-values-to-irq_restore.patch