Skip to contentSkip to conversation

Patch "wlcore: fix error handling in wlcore_event_fw_logger" has been added to the 4.5-stable tree

PATCH [email protected] 1 participant 1 message May 6, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

wlcore: fix error handling in wlcore_event_fw_logger

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
wlcore-fix-error-handling-in-wlcore_event_fw_logger.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 68f37e5d7a2e00306adab033fba6c3042b33e8e1 Mon Sep 17 00:00:00 2001

From: Andrzej Hajda <[email protected]>
Date: Thu, 7 Jan 2016 14:28:50 +0100
Subject: wlcore: fix error handling in wlcore_event_fw_logger

From: Andrzej Hajda <[email protected]>

commit 68f37e5d7a2e00306adab033fba6c3042b33e8e1 upstream.

wlcore_read/wlcore_write can return negative values so it should be assigned to signed variable.

The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2120705

Fixes 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
---
 drivers/net/wireless/ti/wlcore/event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ti/wlcore/event.c +1 -1
@@ -38,7 +38,7 @@
 
 int wlcore_event_fw_logger(struct wl1271 *wl)
 {
-	u32 ret;
+	int ret;
 	struct fw_logger_information fw_log;
 	u8  *buffer;
 	u32 internal_fw_addrbase = WL18XX_DATA_RAM_BASE_ADDRESS;

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/wlcore-fix-error-handling-in-wlcore_event_fw_logger.patch