Skip to contentSkip to conversation

staging: fsl-mc: bus: make checkpatch coding style problem free

PATCH New John Rama 1 participant 1 message May 8, 2016 Staging

lore
Share & tools
lore

John Rama

author
#0 lore raw

PATCH 1/1 staging: fsl-mc: bus: make checkpatch coding style problem free

fixed following coding style problems.

    $checkpatch.pl drivers/staging/fsl-mc/bus/*.c

    -----------------------------------
    drivers/staging/fsl-mc/bus/dprc-driver.c
    -----------------------------------
    CHECK: Alignment should match open parenthesis
    +       if (mc_bus->dprc_attr.version.major < DPRC_MIN_VER_MAJOR ||
    +          (mc_bus->dprc_attr.version.major == DPRC_MIN_VER_MAJOR &&

    -----------------------------------
    drivers/staging/fsl-mc/bus/mc-msi.c
    -----------------------------------
    CHECK: Comparison to NULL could be written "!ops->set_desc"
    +       if (ops->set_desc == NULL)

    CHECK: Comparison to NULL could be written "!chip->irq_write_msi_msg"
    +       if (chip->irq_write_msi_msg == NULL)
---
 drivers/staging/fsl-mc/bus/dprc-driver.c | 4 ++--
 drivers/staging/fsl-mc/bus/mc-msi.c      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/fsl-mc/bus/dprc-driver.c +2 -2
index 7fc4717..c2b4573 100644
@@ -711,8 +711,8 @@ static int dprc_probe(struct fsl_mc_device *mc_dev)
 	}
 
 	if (mc_bus->dprc_attr.version.major < DPRC_MIN_VER_MAJOR ||
-	   (mc_bus->dprc_attr.version.major == DPRC_MIN_VER_MAJOR &&
-	    mc_bus->dprc_attr.version.minor < DPRC_MIN_VER_MINOR)) {
+	    (mc_bus->dprc_attr.version.major == DPRC_MIN_VER_MAJOR &&
+	     mc_bus->dprc_attr.version.minor < DPRC_MIN_VER_MINOR)) {
 		dev_err(&mc_dev->dev,
 			"ERROR: DPRC version %d.%d not supported\n",
 			mc_bus->dprc_attr.version.major,
drivers/staging/fsl-mc/bus/mc-msi.c +2 -2
index e202b2b..56f85c3 100644
@@ -37,7 +37,7 @@ static void fsl_mc_msi_update_dom_ops(struct msi_domain_info *info)
 	/*
 	 * set_desc should not be set by the caller
 	 */
-	if (ops->set_desc == NULL)
+	if (!ops->set_desc)
 		ops->set_desc = fsl_mc_msi_set_desc;
 }
 

@@ -127,7 +127,7 @@ static void fsl_mc_msi_update_chip_ops(struct msi_domain_info *info)
 	/*
 	 * irq_write_msi_msg should not be set by the caller
 	 */
-	if (chip->irq_write_msi_msg == NULL)
+	if (!chip->irq_write_msi_msg)
 		chip->irq_write_msi_msg = fsl_mc_msi_write_msg;
 }
Signature · 1 line
2.1.4