Skip to contentSkip to conversation

tests: assertEquals -> assertEqual

PATCH In review Richard Purdie 2 participants 2 messages May 9, 2016

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 tests: assertEquals -> assertEqual

The preferred form is assertEqaual, assertEquals is deprecated and not present in python v3.

This is v2.7 safe.

Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/tests/codeparser.py +4 -4
index bb820e4..5ea9d84 100644
@@ -302,7 +302,7 @@ bb.data.getVar(a(), d, False)
 
         deps, values = bb.data.build_dependencies("FOO", set(self.d.keys()), set(), set(), self.d)
 
-        self.assertEquals(deps, set(["somevar", "bar", "something", "inexpand", "test", "test2", "a"]))
+        self.assertEqual(deps, set(["somevar", "bar", "something", "inexpand", "test", "test2", "a"]))
 
 
     shelldata = """

@@ -349,7 +349,7 @@ esac
 
         deps, values = bb.data.build_dependencies("FOO", set(self.d.keys()), set(), set(), self.d)
 
-        self.assertEquals(deps, set(["somevar", "inverted"] + execs))
+        self.assertEqual(deps, set(["somevar", "inverted"] + execs))
 
 
     def test_vardeps(self):

@@ -359,7 +359,7 @@ esac
 
         deps, values = bb.data.build_dependencies("FOO", set(self.d.keys()), set(), set(), self.d)
 
-        self.assertEquals(deps, set(["oe_libinstall"]))
+        self.assertEqual(deps, set(["oe_libinstall"]))
 
     def test_vardeps_expand(self):
         self.d.setVar("oe_libinstall", "echo test")

@@ -368,7 +368,7 @@ esac
 
         deps, values = bb.data.build_dependencies("FOO", set(self.d.keys()), set(), set(), self.d)
 
-        self.assertEquals(deps, set(["oe_libinstall"]))
+        self.assertEqual(deps, set(["oe_libinstall"]))
 
     #Currently no wildcard support
     #def test_vardeps_wildcards(self):
bitbake/lib/bb/tests/cow.py +44 -44

129 lines not on this page · raw message

#1 lore raw
Quoted 8 lines

-----Original Message-----
From: [email protected] [mailto:bitbake- [email protected]] On Behalf Of Richard Purdie
Sent: den 9 maj 2016 15:04
To: bitbake-devel
Subject: [bitbake-devel] [PATCH] tests: assertEquals -> assertEqual

The preferred form is assertEqaual, assertEquals is deprecated and

Correct "assertEqaual" to " assertEqual".

//Peter