Skip to contentSkip to conversation

runqueue: Fix missing fakeworker under dry run

PATCH In review Richard Purdie 2 participants 2 messages May 9, 2016

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 runqueue: Fix missing fakeworker under dry run

We shouldn't try and use fakeworker when performing a dry_run. This makes the core match the other fakeworker execution points.

Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/runqueue.py +1 -1
index 0af4678..8d2aa7b 100644
@@ -2095,7 +2095,7 @@ class RunQueueExecuteScenequeue(RunQueueExecute):
             bb.event.fire(startevent, self.cfgData)
 
             taskdep = self.rqdata.dataCache.task_deps[fn]
-            if 'fakeroot' in taskdep and taskname in taskdep['fakeroot']:
+            if 'fakeroot' in taskdep and taskname in taskdep['fakeroot'] and not self.cooker.configuration.dry_run:
                 if not self.rq.fakeworker:
                     self.rq.start_fakeworker(self)
                 self.rq.fakeworker.stdin.write("<runtask>" + pickle.dumps((fn, realtask, taskname, True, self.cooker.collection.get_file_appends(fn), None)) + "</runtask>")
#1 lore raw
Quoted 5 lines · Richard Purdie

We shouldn't try and use fakeworker when performing a dry_run. This makes the core match the other fakeworker execution points.

Signed-off-by Richard Purdie <[email protected]>

Looks good.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics