Skip to contentSkip to conversation

drm/i915: s/DPPL/DPLL/ for SKL DPLLs

PATCH In review [email protected] 3 participants 5 messages May 11, 2016 – May 12, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: s/DPPL/DPLL/ for SKL DPLLs

From: Ville Syrjälä <[email protected]>

SKL DPLLs shouldn't be called DPPLs.

Cc Ander Conselvan de Oliveira <[email protected]>
Fixes 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")
---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +3 -3
index 639bf0209c15..3ac705936b04 100644
@@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {
 
 static const struct dpll_info skl_plls[] = {
 	{ "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs, INTEL_DPLL_ALWAYS_ON },
-	{ "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs,   0 },
-	{ "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs,   0 },
-	{ "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs,   0 },
 	{ NULL, -1, NULL, },
 };
 
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Ro.CI.BAT: failure for drm/i915: s/DPPL/DPLL/ for SKL DPLLs

== Series Details ==

== Series Details ==

Series: drm/i915: s/DPPL/DPLL/ for SKL DPLLs
URL : https://patchwork.freedesktop.org/series/7034/
State : failure

== Summary ==

Series 7034v1 drm/i915: s/DPPL/DPLL/ for SKL DPLLs
http://patchwork.freedesktop.org/api/1.0/series/7034/revisions/1/mbox

Test drv_hangman:

        Subgroup error-state-basic:
                pass       -> FAIL       (ro-ilk1-i5-650)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (ro-ivb2-i7-3770)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                fail       -> PASS       (ro-snb-i7-2620M)
ro-bdw-i5-5250u  total:219  pass:181  dwarn:0   dfail:0   fail:0   skip:38 
ro-bdw-i7-5557U  total:219  pass:205  dwarn:1   dfail:0   fail:0   skip:13 
ro-bdw-i7-5600u  total:219  pass:187  dwarn:0   dfail:0   fail:0   skip:32 
ro-bsw-n3050     total:219  pass:175  dwarn:0   dfail:0   fail:2   skip:42 
ro-byt-n2820     total:218  pass:174  dwarn:0   dfail:0   fail:3   skip:41 
ro-hsw-i3-4010u  total:218  pass:193  dwarn:0   dfail:0   fail:0   skip:25 
ro-hsw-i7-4770r  total:219  pass:194  dwarn:0   dfail:0   fail:0   skip:25 
ro-ilk-i7-620lm  total:219  pass:151  dwarn:0   dfail:0   fail:1   skip:67 
ro-ilk1-i5-650   total:214  pass:151  dwarn:0   dfail:0   fail:2   skip:61 
ro-ivb-i7-3770   total:219  pass:183  dwarn:0   dfail:0   fail:0   skip:36 
ro-ivb2-i7-3770  total:219  pass:187  dwarn:0   dfail:0   fail:0   skip:32 
ro-skl-i7-6700hq total:214  pass:190  dwarn:0   dfail:0   fail:0   skip:24 
ro-snb-i7-2620M  total:219  pass:177  dwarn:0   dfail:0   fail:1   skip:41 

Results at /archive/results/CI_IGT_test/RO_Patchwork_855/

576b6d9 drm-intel-nightly: 2016y-05m-11d-17h-10m-57s UTC integration manifest 64bed24 drm/i915: s/DPPL/DPLL/ for SKL DPLLs

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Re: ✗ Ro.CI.BAT: failure for drm/i915: s/DPPL/DPLL/ for SKL DPLLs

Quoted 6 lines · Patchwork

== Series Details ==

Series: drm/i915: s/DPPL/DPLL/ for SKL DPLLs
URL : https://patchwork.freedesktop.org/series/7034/
State : failure

Quoted 8 lines

== Summary ==

Series 7034v1 drm/i915: s/DPPL/DPLL/ for SKL DPLLs
http://patchwork.freedesktop.org/api/1.0/series/7034/revisions/1/mbox

Test drv_hangman:

        Subgroup error-state-basic:
                pass       -> FAIL       (ro-ilk1-i5-650)

(drv_hangman:6088) CRITICAL: contents of i915_error_state: 'no error state collected' (expected not 'no error state collected'

Happens on that machine a lot. Bug filed:
https://bugs.freedesktop.org/show_bug.cgi?id=95364

Quoted 25 lines

Test kms_flip:

        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (ro-ivb2-i7-3770)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                fail       -> PASS       (ro-snb-i7-2620M)
ro-bdw-i5-5250u  total:219  pass:181  dwarn:0   dfail:0   fail:0   skip:38 
ro-bdw-i7-5557U  total:219  pass:205  dwarn:1   dfail:0   fail:0   skip:13 
ro-bdw-i7-5600u  total:219  pass:187  dwarn:0   dfail:0   fail:0   skip:32 
ro-bsw-n3050     total:219  pass:175  dwarn:0   dfail:0   fail:2   skip:42 
ro-byt-n2820     total:218  pass:174  dwarn:0   dfail:0   fail:3   skip:41 
ro-hsw-i3-4010u  total:218  pass:193  dwarn:0   dfail:0   fail:0   skip:25 
ro-hsw-i7-4770r  total:219  pass:194  dwarn:0   dfail:0   fail:0   skip:25 
ro-ilk-i7-620lm  total:219  pass:151  dwarn:0   dfail:0   fail:1   skip:67 
ro-ilk1-i5-650   total:214  pass:151  dwarn:0   dfail:0   fail:2   skip:61 
ro-ivb-i7-3770   total:219  pass:183  dwarn:0   dfail:0   fail:0   skip:36 
ro-ivb2-i7-3770  total:219  pass:187  dwarn:0   dfail:0   fail:0   skip:32 
ro-skl-i7-6700hq total:214  pass:190  dwarn:0   dfail:0   fail:0   skip:24 
ro-snb-i7-2620M  total:219  pass:177  dwarn:0   dfail:0   fail:1   skip:41 

Results at /archive/results/CI_IGT_test/RO_Patchwork_855/

576b6d9 drm-intel-nightly: 2016y-05m-11d-17h-10m-57s UTC integration manifest 64bed24 drm/i915: s/DPPL/DPLL/ for SKL DPLLs

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#3 lore raw
In reply to [email protected]
Quoted 3 lines · On Wed, 2016-05-11 at 22:04 +0300, [email protected] wrote:

From: Ville Syrjälä <[email protected]>

SKL DPLLs shouldn't be called DPPLs.

I really didn't notice that typo. Thanks for fixing.

Quoted 24 lines
Cc Ander Conselvan de Oliveira <[email protected]>
Fixes 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +0 -0
index 639bf0209c15..3ac705936b04 100644
@@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {


 static const struct dpll_info skl_plls[] = {
  { "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs, INTEL_DPLL_ALWAYS_ON },

drivers/gpu/drm/i915/intel_dpll_mgr.c +3 -3
-	{ "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs,   0 },
-	{ "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs,   0 },
-	{ "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs,   0 },
Quoted 3 lines

  { NULL, -1, NULL, },
 };

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 8 lines · Ander Conselvan De Oliveira
Quoted 3 lines · On Wed, 2016-05-11 at 22:04 +0300, [email protected] wrote:

From: Ville Syrjälä <[email protected]>

SKL DPLLs shouldn't be called DPPLs.

I really didn't notice that typo. Thanks for fixing.

Thanks. Pushed to dinq.

Quoted 28 lines
Quoted 28 lines
Cc Ander Conselvan de Oliveira <[email protected]>
Fixes 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +0 -0
index 639bf0209c15..3ac705936b04 100644
@@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {


 static const struct dpll_info skl_plls[] = {
  { "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs, INTEL_DPLL_ALWAYS_ON },

drivers/gpu/drm/i915/intel_dpll_mgr.c +3 -3
-	{ "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs,   0 },
-	{ "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs,   0 },
-	{ "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs,   0 },
+	{ "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs,   0 },

  { NULL, -1, NULL, },
 };

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx