knotty: Ensure consolelog file handle is closed

PATCH New Richard Purdie 1 participant 1 message May 11, 2016

Share & tools

Richard Purdie

author

2016-05-11 22:06 UTC #0 lore raw

PATCH 1/1 knotty: Ensure consolelog file handle is closed

If we don't close the console log file handle, python prints a warning about unclosed file handles upon exit which is annoying.

Signed-off-by Richard Purdie <[email protected]>

bitbake/lib/bb/ui/knotty.py +5 -0

index 903d72b..85a71f4 100644
@@ -278,6 +278,7 @@ def main(server, eventHandler, params, tf = TerminalFilter):
         server.terminateServer()
         return
 
+    consolelog = None
     if consolelogfile and not params.options.show_environment and not params.options.show_versions:
         bb.utils.mkdirhier(os.path.dirname(consolelogfile))
         conlogformat = bb.msg.BBLogFormatter(format_str)

@@ -591,4 +592,8 @@ def main(server, eventHandler, params, tf = TerminalFilter):
         if e.errno == errno.EPIPE:
             pass
 
+    if consolelog:
+        logger.removeHandler(consolelog)
+        consolelog.close()
+
     return return_value