Patch "pinctrl: at91-pio4: fix pull-up/down logic" has been added to the 4.5-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
pinctrl: at91-pio4: fix pull-up/down logic
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pinctrl-at91-pio4-fix-pull-up-down-logic.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
5305a7b7e860bb40ab226bc7d58019416073948aMon Sep 17 00:00:00 2001
From: Ludovic Desroches <[email protected]>
Date: Tue, 19 Apr 2016 16:03:45 +0200
Subject: pinctrl: at91-pio4: fix pull-up/down logic
From: Ludovic Desroches <[email protected]>
commit 5305a7b7e860bb40ab226bc7d58019416073948a upstream.
The default configuration of a pin is often with a value in the pull-up/down field at chip reset. So, even if the internal logic of the controller prevents writing a configuration with pull-up and pull-down at the same time, we must ensure explicitly this condition before writing the register.
This was leading to a pull-down condition not taken into account for instance.
--- drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pinctrl/pinctrl-at91-pio4.c +2 -0
@@ -722,9 +722,11 @@ static int atmel_conf_pin_config_group_sbreak ;case PIN_CONFIG_BIAS_PULL_UP : conf |=ATMEL_PIO_PUEN_MASK ; + conf &= (~ATMEL_PIO_PDEN_MASK );break ;case PIN_CONFIG_BIAS_PULL_DOWN : conf |=ATMEL_PIO_PDEN_MASK ; + conf &= (~ATMEL_PIO_PUEN_MASK );break ;case PIN_CONFIG_DRIVE_OPEN_DRAIN :if (arg ==0 )
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/pinctrl-at91-pio4-fix-pull-up-down-logic.patch