Skip to contentSkip to conversation

phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

PATCH Superseded Axel Lin 2 participants 3 messages May 23, 2016 Generic PHY framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

---
 drivers/phy/phy-brcm-sata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/phy-brcm-sata.c +1 -1
index 6c4c5cb..5d7fad4b 100644
@@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
 		rc = -ENODEV;
 	};
 
-	return 0;
+	return rc;
 }
 
 static const struct phy_ops phy_ops = {
Signature · 1 line
2.5.0
#1 lore raw

Hi,

Quoted 1 line · Axel Lin

however obvious the patch maybe, it's nice to add a little commit log.

Thanks
Kishon

Quoted 18 lines
---
 drivers/phy/phy-brcm-sata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/phy-brcm-sata.c +1 -1
index 6c4c5cb..5d7fad4b 100644
@@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
 		rc = -ENODEV;
 	};
 
-	return 0;
+	return rc;
 }
 
 static const struct phy_ops phy_ops = {
author
#2 lore raw

2016-05-23 13:28 GMT+08:00 Kishon Vijay Abraham I <[email protected]>:

Quoted 6 lines

Hi,

Quoted 1 line · Axel Lin

however obvious the patch maybe, it's nice to add a little commit log.

I think the subject line is already very clear about the intention. In additional, checkpatch does not complain.