Patch "fs/cifs: correctly to anonymous authentication for the LANMAN authentication" has been added to the 4.4-stable tree
This is a note to let you know that I've just added the patch titled
fs/cifs: correctly to anonymous authentication for the LANMAN authentication
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
fs-cifs-correctly-to-anonymous-authentication-for-the-lanman-authentication.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
fa8f3a354bb775ec586e4475bcb07f7dece97e0cMon Sep 17 00:00:00 2001
From: Stefan Metzmacher <[email protected]>
Date: Tue, 3 May 2016 10:52:30 +0200
Subject: fs/cifs: correctly to anonymous authentication for the LANMAN authentication
From: Stefan Metzmacher <[email protected]>
commit fa8f3a354bb775ec586e4475bcb07f7dece97e0c upstream.
Only server which map unknown users to guest will allow access using a non-null LMChallengeResponse.
For Samba it's the "map to guest = bad user" option.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11913
--- fs/cifs/sess.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-)
fs/cifs/sess.c +16 -12
@@ -678,20 +678,24 @@ sess_auth_lanman(struct sess_data *sess_ pSMB->req.hdr.Flags2 &= ~SMBFLG2_UNICODE ; -/* no capabilities flags in old lanman negotiation */ - pSMB->old_req.PasswordLength =cpu_to_le16 (CIFS_AUTH_RESP_SIZE ); +if (ses->user_name !=NULL ) { +/* no capabilities flags in old lanman negotiation */ + pSMB->old_req.PasswordLength =cpu_to_le16 (CIFS_AUTH_RESP_SIZE ); -/* Calculate hash with password and copy into bcc_ptr. -* Encryption Key (stored as in cryptkey) gets used if the -* security mode bit in Negottiate Protocol response states -* to use challenge/response method (i.e. Password bit is 1). -*/ - rc =calc_lanman_hash (ses->password, ses->server->cryptkey, - ses->server->sec_mode &SECMODE_PW_ENCRYPT ? - true : false, lnm_session_key); +/* Calculate hash with password and copy into bcc_ptr. +* Encryption Key (stored as in cryptkey) gets used if the +* security mode bit in Negottiate Protocol response states +* to use challenge/response method (i.e. Password bit is 1). +*/ + rc =calc_lanman_hash (ses->password, ses->server->cryptkey, + ses->server->sec_mode &SECMODE_PW_ENCRYPT ? + true : false, lnm_session_key); -memcpy (bcc_ptr, (char *)lnm_session_key,CIFS_AUTH_RESP_SIZE ); - bcc_ptr +=CIFS_AUTH_RESP_SIZE ; +memcpy (bcc_ptr, (char *)lnm_session_key,CIFS_AUTH_RESP_SIZE ); + bcc_ptr +=CIFS_AUTH_RESP_SIZE ; + }else { + pSMB->old_req.PasswordLength =0 ; + }/* * can not sign if LANMAN negotiated so no need
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/fs-cifs-correctly-to-anonymous-authentication-for-the-ntlm-v1-authentication.patch queue-4.4/fs-cifs-correctly-to-anonymous-authentication-for-the-lanman-authentication.patch queue-4.4/fs-cifs-correctly-to-anonymous-authentication-for-the-ntlm-v2-authentication.patch queue-4.4/fs-cifs-correctly-to-anonymous-authentication-via-ntlmssp.patch