Skip to contentSkip to conversation

FAILED: patch "[PATCH] md: md.c: fix oops in mddev_suspend for raid0" failed to apply to 4.5-stable tree

PATCH [email protected] 1 participant 1 message May 30, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.5-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 092398dce8c2406bfb0c9eebc3e764ff2ddb62a8 Mon Sep 17 00:00:00 2001

From: Heinz Mauelshagen <[email protected]>
Date: Tue, 3 May 2016 19:43:57 +0200
Subject: [PATCH] md: md.c: fix oops in mddev_suspend for raid0

Introduced by upstream commit 70d9798b95562abac005d4ba71d28820f9a201eb

The raid0 personality does not create mddev->thread as oposed to other personalities leading to its unconditional access in mddev_suspend() causing an oops.

Patch checks for mddev->thread in order to keep the intention of aforementioned commit.

Fixes 70d9798b9556 ("MD: warn for potential deadlock")
drivers/md/md.c +1 -1
index 06f6e81f1516..23c6d732a374 100644
@@ -307,7 +307,7 @@ static blk_qc_t md_make_request(struct request_queue *q, struct bio *bio)
  */
 void mddev_suspend(struct mddev *mddev)
 {
-	WARN_ON_ONCE(current == mddev->thread->tsk);
+	WARN_ON_ONCE(mddev->thread && current == mddev->thread->tsk);
 	if (mddev->suspended++)
 		return;
 	synchronize_rcu();