Skip to contentSkip to conversation

Patch "usb: misc: usbtest: fix pattern tests for scatterlists." has been added to the 4.5-stable tree

PATCH [email protected] 1 participant 1 message May 30, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: misc: usbtest: fix pattern tests for scatterlists.

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-misc-usbtest-fix-pattern-tests-for-scatterlists.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cdc77c82a8286b1181b81b6e5ef60c8e83ded7bc Mon Sep 17 00:00:00 2001

From: Mathias Nyman <[email protected]>
Date: Mon, 2 May 2016 11:39:03 +0300
Subject: usb: misc: usbtest: fix pattern tests for scatterlists.

From: Mathias Nyman <[email protected]>

commit cdc77c82a8286b1181b81b6e5ef60c8e83ded7bc upstream.

The current implemenentation restart the sent pattern for each entry in the sg list. The receiving end expects a continuous pattern, and test will fail unless scatterilst entries happen to be aligned with the pattern

Fix this by calculating the pattern byte based on total sent size instead of just the current sg entry.

Fixes 8b5249019352 ("[PATCH] USB: usbtest: scatterlist OUT data pattern testing")
---
 drivers/usb/misc/usbtest.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/misc/usbtest.c +3 -1
@@ -529,6 +529,7 @@ static struct scatterlist *
 alloc_sglist(int nents, int max, int vary, struct usbtest_dev *dev, int pipe)
 {
 	struct scatterlist	*sg;
+	unsigned int		n_size = 0;
 	unsigned		i;
 	unsigned		size = max;
 	unsigned		maxpacket =
@@ -561,7 +562,8 @@ alloc_sglist(int nents, int max, int var
 			break;
 		case 1:
 			for (j = 0; j < size; j++)
-				*buf++ = (u8) ((j % maxpacket) % 63);
+				*buf++ = (u8) (((j + n_size) % maxpacket) % 63);
+			n_size += size;
 			break;
 		}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/usb-misc-usbtest-fix-pattern-tests-for-scatterlists.patch