Patch "USB: serial: mxuport: fix use-after-free in probe error path" has been added to the 4.5-stable tree

This is a note to let you know that I've just added the patch titled

USB: serial: mxuport: fix use-after-free in probe error path

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-mxuport-fix-use-after-free-in-probe-error-path.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Johan Hovold <[email protected]>
Date: Sun, 8 May 2016 20:08:01 +0200
Subject: USB: serial: mxuport: fix use-after-free in probe error path

From: Johan Hovold <[email protected]>

commit 9e45284984096314994777f27e1446dfbfd2f0d7 upstream.

The interface read and event URBs are submitted in attach, but were never explicitly unlinked by the driver. Instead the URBs would have been killed by usb-serial core on disconnect.

In case of a late probe error (e.g. due to failed minor allocation), disconnect is never called and we could end up with active URBs for an unbound interface. This in turn could lead to deallocated memory being dereferenced in the completion callbacks.

driver")

---
 drivers/usb/serial/mxuport.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

@@ -1259,6 +1259,15 @@ static int mxuport_attach(struct usb_ser
 	return 0;
 }
 
+static void mxuport_release(struct usb_serial *serial)
+{
+	struct usb_serial_port *port0 = serial->port[0];
+	struct usb_serial_port *port1 = serial->port[1];
+
+	usb_serial_generic_close(port1);
+	usb_serial_generic_close(port0);
+}
+
 static int mxuport_open(struct tty_struct *tty, struct usb_serial_port *port)
 {
 	struct mxuport_port *mxport = usb_get_serial_port_data(port);

@@ -1361,6 +1370,7 @@ static struct usb_serial_driver mxuport_
 	.probe			= mxuport_probe,
 	.port_probe		= mxuport_port_probe,
 	.attach			= mxuport_attach,
+	.release		= mxuport_release,
 	.calc_num_ports		= mxuport_calc_num_ports,
 	.open			= mxuport_open,
 	.close			= mxuport_close,

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/usb-serial-quatech2-fix-use-after-free-in-probe-error-path.patch queue-4.5/usb-serial-option-add-support-for-cinterion-ph8-and-ahxx.patch queue-4.5/usb-serial-io_edgeport-fix-memory-leaks-in-attach-error-path.patch queue-4.5/usb-serial-mxuport-fix-use-after-free-in-probe-error-path.patch queue-4.5/usb-serial-option-add-even-more-zte-device-ids.patch queue-4.5/usb-serial-keyspan-fix-use-after-free-in-probe-error-path.patch queue-4.5/usb-serial-option-add-more-zte-device-ids.patch queue-4.5/usb-serial-io_edgeport-fix-memory-leaks-in-probe-error-path.patch