Skip to contentSkip to conversation

ixgbe: Correct reporting of timestamping for x550

PATCH New Tony Nguyen 2 participants 3 messages Jun 1, 2016

Subsystems (2)
Network drivers Intel Ethernet
lore
Share & tools
lore

Tony Nguyen

author maintainer
#0 lore raw

PATCH 1/1 ixgbe: Correct reporting of timestamping for x550

Update ixgbe_ethtool_get_ts_info() to show that x550 supports hardware timestamping of all packets.

Reported-by Guy Harris <[email protected]>
Signed-off-by Tony Nguyen <[email protected]>
Signed-off-by Jacob Keller <[email protected]>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +6 -2
index f1d2fc1..716e643 100644
@@ -2993,10 +2993,15 @@ static int ixgbe_get_ts_info(struct net_device *dev,
 {
 	struct ixgbe_adapter *adapter = netdev_priv(dev);
 
+	/* we always support timestamping disabled */
+	info->rx_filters = BIT(HWTSTAMP_FILTER_NONE);
+
 	switch (adapter->hw.mac.type) {
 	case ixgbe_mac_X550:
 	case ixgbe_mac_X550EM_x:
 	case ixgbe_mac_x550em_a:
+		info->rx_filters |= BIT(HWTSTAMP_FILTER_ALL);
+		/* fallthrough */
 	case ixgbe_mac_X540:
 	case ixgbe_mac_82599EB:
 		info->so_timestamping =

@@ -3016,8 +3021,7 @@ static int ixgbe_get_ts_info(struct net_device *dev,
 			BIT(HWTSTAMP_TX_OFF) |
 			BIT(HWTSTAMP_TX_ON);
 
-		info->rx_filters =
-			BIT(HWTSTAMP_FILTER_NONE) |
+		info->rx_filters |=
 			BIT(HWTSTAMP_FILTER_PTP_V1_L4_SYNC) |
 			BIT(HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ) |
 			BIT(HWTSTAMP_FILTER_PTP_V2_EVENT);
Signature · 1 line
2.4.0
#2 lore raw

PATCH 1/1 ixgbe: Correct reporting of timestamping for x550

In reply to Tony Nguyen
Quoted 11 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Tony Nguyen
Sent: Wednesday, June 01, 2016 9:51 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550

Update ixgbe_ethtool_get_ts_info() to show that x550 supports hardware timestamping of all packets.

Quoted 6 lines
Reported-by Guy Harris <[email protected]>
Signed-off-by Tony Nguyen <[email protected]>
Signed-off-by Jacob Keller <[email protected]>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Tested-by Andrew Bowers <[email protected]>

Ethtool correctly reports hardware timestamping capabilities of the device