Skip to contentSkip to conversation

fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

PATCH In review Geert Uytterhoeven 3 participants 5 messages Jun 5, 2016 – Jun 7, 2016 FPGA manager framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

If NO_DMA=y:

ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
v2:
- Add Reviewed-by,
- Updated error message for recent kernels,
- Submit to Greg, as requested by Alan.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Geert Uytterhoeven

If NO_DMA=y:

ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Quoted 7 lines

---
v2:
- Add Reviewed-by,
- Updated error message for recent kernels,
- Submit to Greg, as requested by Alan.

Hi Geert,

Thank you!

Alan

Quoted 20 lines
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 1 line
1.9.1
#2 lore raw

Hi Alan, Geert

Quoted 16 lines · atull
Quoted 6 lines · Geert Uytterhoeven

If NO_DMA=y:

ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Quoted 7 lines

---
v2:
- Add Reviewed-by,
- Updated error message for recent kernels,
- Submit to Greg, as requested by Alan.

Quoted 3 lines

Hi Geert,

Thank you!

We should probably pick this one over Sudip's duplicate?

Cheers,

Moritz

#3 lore raw
Quoted 21 lines · Moritz Fischer

Hi Alan, Geert

Quoted 18 lines · atull
Quoted 6 lines · Geert Uytterhoeven

If NO_DMA=y:

ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Quoted 7 lines

---
v2:
- Add Reviewed-by,
- Updated error message for recent kernels,
- Submit to Greg, as requested by Alan.

Hi Geert,

Quoted 8 lines
Quoted 1 line

Thank you!

We should probably pick this one over Sudip's duplicate?

Cheers,

Moritz

Yes, Geert originally submitted 11/9/2015.

Alan

Acked-by on v2 1/1
#4 lore raw
In reply to Geert Uytterhoeven
Quoted 8 lines · Geert Uytterhoeven

If NO_DMA=y:

ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Thanks!
Alan

Quoted 25 lines

---
v2:
- Add Reviewed-by,
- Updated error message for recent kernels,
- Submit to Greg, as requested by Alan.

---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
Signature · 1 line
1.9.1