Skip to contentSkip to conversation

Patch "ext4: fix check of dqget() return value in ext4_ioctl_setproject()" has been added to the 4.5-stable tree

PATCH [email protected] 1 participant 1 message Jun 5, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ext4: fix check of dqget() return value in ext4_ioctl_setproject()

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ext4-fix-check-of-dqget-return-value-in-ext4_ioctl_setproject.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ff0bc08454917964291f72ee5b8eca66de4bc250 Mon Sep 17 00:00:00 2001

From: Seth Forshee <[email protected]>
Date: Thu, 5 May 2016 10:52:38 -0400
Subject: ext4: fix check of dqget() return value in ext4_ioctl_setproject()

From: Seth Forshee <[email protected]>

commit ff0bc08454917964291f72ee5b8eca66de4bc250 upstream.

A failed call to dqget() returns an ERR_PTR() and not null. Fix the check in ext4_ioctl_setproject() to handle this correctly.

Fixes 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
---
 fs/ext4/ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ext4/ioctl.c +1 -1
@@ -365,7 +365,7 @@ static int ext4_ioctl_setproject(struct
 		struct dquot *transfer_to[MAXQUOTAS] = { };
 
 		transfer_to[PRJQUOTA] = dqget(sb, make_kqid_projid(kprojid));
-		if (transfer_to[PRJQUOTA]) {
+		if (!IS_ERR(transfer_to[PRJQUOTA])) {
 			err = __dquot_transfer(inode, transfer_to);
 			dqput(transfer_to[PRJQUOTA]);
 			if (err)

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/ext4-fix-check-of-dqget-return-value-in-ext4_ioctl_setproject.patch