Skip to contentSkip to conversation

ASoC: dapm: Fix to return correct path list in is_connected_ep.

PATCH In review [email protected] 2 participants 2 messages Jun 15, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dapm: Fix to return correct path list in is_connected_ep.

From: Jeeja KP <[email protected]>

In is_connected_ep, when custom_stop_condition is true, need to return the correct paths instead of con which is 0.

Fixes 6742064aef7f('ASoC: dapm: support user-defined stop condition in dai_get_connected_widgets')
---
 sound/soc/soc-dapm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/soc-dapm.c +4 -2
index db781f6..3c3f027 100644
@@ -1092,8 +1092,10 @@ static __always_inline int is_connected_ep(struct snd_soc_dapm_widget *widget,
 	if (list)
 		list_add_tail(&widget->work_list, list);
 
-	if (custom_stop_condition && custom_stop_condition(widget, dir))
-		return con;
+	if (custom_stop_condition && custom_stop_condition(widget, dir)) {
+		widget->endpoints[dir] = 1;
+		return widget->endpoints[dir];
+	}
 
 	if ((widget->is_ep & SND_SOC_DAPM_DIR_TO_EP(dir)) && widget->connected) {
 		widget->endpoints[dir] = snd_soc_dapm_suspend_check(widget);
Signature · 1 line
2.5.0
maintainer
#1 lore raw

Applied "ASoC: dapm: Fix to return correct path list in is_connected_ep." to the asoc tree

The patch

ASoC: dapm: Fix to return correct path list in is_connected_ep.

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 09464974eaa8325c4cd22c3cab743a110644fb31 Mon Sep 17 00:00:00 2001

From: Jeeja KP <[email protected]>
Date: Wed, 15 Jun 2016 11:16:55 +0530
Subject: [PATCH] ASoC: dapm: Fix to return correct path list in
is_connected_ep.

In is_connected_ep, when custom_stop_condition is true, need to return the correct paths instead of con which is 0.

Fixes 6742064aef7f('ASoC: dapm: support user-defined stop condition in dai_get_connected_widgets')
---
 sound/soc/soc-dapm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/soc-dapm.c +4 -2
index db781f6faaec..3c3f027d21bd 100644
@@ -1092,8 +1092,10 @@ static __always_inline int is_connected_ep(struct snd_soc_dapm_widget *widget,
 	if (list)
 		list_add_tail(&widget->work_list, list);
 
-	if (custom_stop_condition && custom_stop_condition(widget, dir))
-		return con;
+	if (custom_stop_condition && custom_stop_condition(widget, dir)) {
+		widget->endpoints[dir] = 1;
+		return widget->endpoints[dir];
+	}
 
 	if ((widget->is_ep & SND_SOC_DAPM_DIR_TO_EP(dir)) && widget->connected) {
 		widget->endpoints[dir] = snd_soc_dapm_suspend_check(widget);
Signature · 1 line
2.8.1