Skip to contentSkip to conversation

selftests/exec: Makefile is a run-time dependency, add it to the install list

PATCH In review Yannick Brosseau 2 participants 2 messages Jun 15, 2016

Subsystems (2)
Kselftest exec and binfmt
lore
Share & tools
lore

Yannick Brosseau

author
#0 lore raw

PATCH 1/1 selftests/exec: Makefile is a run-time dependency, add it to the install list

The execveat test try to exec the Makefile file and expect an EACCES results. When running the test in the installed destination it would fail with ENOENT since the file is not there.
Add Makefile to the TEST_FILES list so it's copied at install time.

Signed-off-by Yannick Brosseau <[email protected]>
---
 tools/testing/selftests/exec/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/exec/Makefile +2 -1
index 4e400eb..d430060 100644
@@ -18,7 +18,8 @@ execveat.denatured: execveat
 	$(CC) $(CFLAGS) -o $@ $^
 
 TEST_PROGS := execveat
-TEST_FILES := $(DEPS)
+# Makefile is a run-time dependency, since it's accessed by the execveat test
+TEST_FILES := $(DEPS) Makefile
 
 include ../lib.mk
Signature · 1 line
2.8.1
#1 lore raw
Quoted 16 lines · Yannick Brosseau

The execveat test try to exec the Makefile file and expect an EACCES results. When running the test in the installed destination it would fail with ENOENT since the file is not there.
Add Makefile to the TEST_FILES list so it's copied at install time.

Signed-off-by Yannick Brosseau <[email protected]>
---
 tools/testing/selftests/exec/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/exec/Makefile +0 -0
index 4e400eb..d430060 100644

tools/testing/selftests/exec/Makefile execveat.denatured: execveat · line 25

Quoted 9 lines
tools/testing/selftests/exec/Makefile +2 -1
@@ -18,7 +18,8 @@ execveat.denatured: execveat
 	$(CC) $(CFLAGS) -o $@ $^
 
 TEST_PROGS := execveat
-TEST_FILES := $(DEPS)
+# Makefile is a run-time dependency, since it's accessed by the execveat test
+TEST_FILES := $(DEPS) Makefile
 
 include ../lib.mk

Thanks. Applied and queued for the next rc in linux-kselftest fixes branch

-- Shuah