ASoC: core: Remove selects of regmap buses
Mark Brown
maintainerPATCH 1/1 ASoC: core: Remove selects of regmap buses
We used to have code wrapping the regmap I2C and SPI buses as part of the conversion of ASoC drivers from using the ASoC level I/O to the regmap level I/O. Since all drivers have now been converted and the core code removed we can remove the per-bus selects and instead just select the regmap core.
--- sound/soc/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/Kconfig +1 -2
@@ -7,8 +7,7 @@ menuconfig SND_SOC select SND_PCM select AC97_BUS if SND_SOC_AC97_BUS select SND_JACK - select REGMAP_I2C if I2C - select REGMAP_SPI if SPI_MASTER + select REGMAP ---help--- If you want ASoC support, you should say Y here and also to the
Signature · 1 line
2.8.1
Quoted 5 lines · Mark Brown
We used to have code wrapping the regmap I2C and SPI buses as part of the conversion of ASoC drivers from using the ASoC level I/O to the regmap level I/O. Since all drivers have now been converted and the core code removed we can remove the per-bus selects and instead just select the regmap core.
I think there is a fair amount of CODEC drivers that don't yet select REGMAP_{SPI,I2C} even though they use it. Merging this as is would break them I'd assume.
Mark Brown
maintainerQuoted 11 lines · Lars-Peter Clausen
Quoted 5 lines · Mark Brown
We used to have code wrapping the regmap I2C and SPI buses as part of the conversion of ASoC drivers from using the ASoC level I/O to the regmap level I/O. Since all drivers have now been converted and the core code removed we can remove the per-bus selects and instead just select the regmap core.
I think there is a fair amount of CODEC drivers that don't yet select REGMAP_{SPI,I2C} even though they use it. Merging this as is would break them I'd assume.
Yes, that's why I've not actually applied this yet.