Skip to contentSkip to conversation

Patch "tipc: check nl sock before parsing nested attributes" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jun 17, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

tipc: check nl sock before parsing nested attributes

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
tipc-check-nl-sock-before-parsing-nested-attributes.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Fri Jun 17 08:34:39 PDT 2016

From: Richard Alpe <[email protected]>
Date: Mon, 16 May 2016 11:14:54 +0200
Subject: tipc: check nl sock before parsing nested attributes

From: Richard Alpe <[email protected]>

[ Upstream commit 45e093ae2830cd1264677d47ff9a95a71f5d9f9c ]

Make sure the socket for which the user is listing publication exists before parsing the socket netlink attributes.

Prior to this patch a call without any socket caused a NULL pointer dereference in tipc_nl_publ_dump().

---
 net/tipc/socket.c |    3 +++
 1 file changed, 3 insertions(+)
net/tipc/socket.c +3 -0
@@ -2807,6 +2807,9 @@ int tipc_nl_publ_dump(struct sk_buff *sk
 		if (err)
 			return err;
 
+		if (!attrs[TIPC_NLA_SOCK])
+			return -EINVAL;
+
 		err = nla_parse_nested(sock, TIPC_NLA_SOCK_MAX,
 				       attrs[TIPC_NLA_SOCK],
 				       tipc_nl_sock_policy);

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/tipc-check-nl-sock-before-parsing-nested-attributes.patch queue-4.6/tipc-fix-nametable-publication-field-in-nl-compat.patch