Skip to contentSkip to conversation

autobuilder/Autobuilder.p: Add missing import of buildbot.util.

PATCH In review Aníbal Limón 2 participants 3 messages Jun 17, 2016 – Jun 20, 2016

lore
Share & tools
lore

Aníbal Limón

author
#0 lore raw

PATCH 1/1 autobuilder/Autobuilder.p: Add missing import of buildbot.util.

When try to start Autobuilder fails with the next exception,

2016-06-07 17:06:45-0500 [-] LOADING CONFIG FILE
2016-06-07 17:06:45-0500 [-] error while parsing config file:

Traceback (most recent call last):
File
"/home/alimon/repos/yocto-autobuilder/lib/python2.7/site-packages/Twisted-12.2.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks
......
......
......
File
"/home/alimon/repos/yocto-autobuilder/lib/python2.7/site-packages/autobuilder/Autobuilder.py",
line 54, in createBuildsets
util.naturalSort(buildersSorted)
exceptions.NameError: global name 'util' is not defined

Signed-off-by Aníbal Limón <[email protected]>
---
 lib/python2.7/site-packages/autobuilder/Autobuilder.py | 1 +
 1 file changed, 1 insertion(+)
lib/python2.7/site-packages/autobuilder/Autobuilder.py +1 -0
index 6c3e578..23f0a74 100644
@@ -19,6 +19,7 @@ from buildbot.schedulers.basic  import SingleBranchScheduler
 from buildbot.changes import filter
 from buildbot.changes.pb import PBChangeSource
 from buildbot.changes.gitpoller import *
+from buildbot import util
 from lib.ABTools import capitalize
 import ast
 import BuildSet
Signature · 1 line
2.1.4
#1 lore raw
Quoted 21 lines · Aníbal Limón

When try to start Autobuilder fails with the next exception,

2016-06-07 17:06:45-0500 [-] LOADING CONFIG FILE
2016-06-07 17:06:45-0500 [-] error while parsing config file:

Traceback (most recent call last):
          File "/home/alimon/repos/yocto-autobuilder/lib/python2.7/site- packages/Twisted-12.2.0-py2.7-linux- x86_64.egg/twisted/internet/defer.py",
line 551, in _runCallbacks
......
......
......
          File "/home/alimon/repos/yocto-autobuilder/lib/python2.7/site- packages/autobuilder/Autobuilder.py",
line 54, in createBuildsets util.naturalSort(buildersSorted) exceptions.NameError: global name 'util' is not defined

Quoted 1 line
Signed-off-by Aníbal Limón <[email protected]>

Pulled into master.

I'm going to have a few patches today to pull in. One from Bill Randle, and if you have the rebase done for our bitbakeshell branch, that as well, so we might want to consider getting production updated.

Have we run your BitbakeShell branch of the devel cluster (or any cluster not on a single machine, which is generally where we find issues) yet?

-b

Quoted 18 lines

---
 lib/python2.7/site-packages/autobuilder/Autobuilder.py | 1 +

 1 file changed, 1 insertion(+)
lib/python2.7/site-packages/autobuilder/Autobuilder.py +0 -0
index 6c3e578..23f0a74 100644
@@ -19,6 +19,7 @@ from buildbot.schedulers.basic  import

SingleBranchScheduler
 from buildbot.changes import filter
 from buildbot.changes.pb import PBChangeSource
 from buildbot.changes.gitpoller import *
+from buildbot import util
 from lib.ABTools import capitalize
 import ast
 import BuildSet

author
#2 lore raw
Quoted 26 lines · Beth 'pidge' Flanagan
Quoted 21 lines · Aníbal Limón

When try to start Autobuilder fails with the next exception,

2016-06-07 17:06:45-0500 [-] LOADING CONFIG FILE
2016-06-07 17:06:45-0500 [-] error while parsing config file:

Traceback (most recent call last):
File
"/home/alimon/repos/yocto-autobuilder/lib/python2.7/site- packages/Twisted-12.2.0-py2.7-linux- x86_64.egg/twisted/internet/defer.py",
line 551, in _runCallbacks
......
......
......
File
"/home/alimon/repos/yocto-autobuilder/lib/python2.7/site- packages/autobuilder/Autobuilder.py",
line 54, in createBuildsets
util.naturalSort(buildersSorted)
exceptions.NameError: global name 'util' is not defined

Quoted 1 line
Signed-off-by Aníbal Limón <[email protected]>

Pulled into master.

Quoted 7 lines

I'm going to have a few patches today to pull in. One from Bill Randle, and if you have the rebase done for our bitbakeshell branch, that as well, so we might want to consider getting production updated.

Have we run your BitbakeShell branch of the devel cluster (or any cluster not on a single machine, which is generally where we find issues) yet?

I ran into my machine and it works ok, but for BitbakeShell related changes we need to wait the integration of other related changes into Error report web because with the new changes the AB starts to send a new field to the ERW and it possible could cause problems.

alimon

Quoted 22 lines

-b

Quoted 18 lines
---
 lib/python2.7/site-packages/autobuilder/Autobuilder.py | 1 +
 1 file changed, 1 insertion(+)
lib/python2.7/site-packages/autobuilder/Autobuilder.py +0 -0
index 6c3e578..23f0a74 100644
@@ -19,6 +19,7 @@ from buildbot.schedulers.basic  import

SingleBranchScheduler
from buildbot.changes import filter
from buildbot.changes.pb import PBChangeSource
from buildbot.changes.gitpoller import *
+from buildbot import util
from lib.ABTools import capitalize
import ast
import BuildSet