lib: Make strreplace prototype compatible with C++

Since "new" is a keyword in C++, this breaks compilation when string.h is included in a C++ file. For example, this affects VirtualBox Guest Additions.

https://www.virtualbox.org/pipermail/vbox-dev/2015-August/013368.html

Signed-off-by Matt Ullman <[email protected]>

---
Thanks for your feedback and I agree. I've made the requested changes.

 include/linux/string.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/linux/string.h +1 -1

index 26b6f6a..1e5183b 100644
@@ -115,7 +115,7 @@ extern int memcmp(const void *,const void *,__kernel_size_t);
 extern void * memchr(const void *,int,__kernel_size_t);
 #endif
 void *memchr_inv(const void *s, int c, size_t n);
-char *strreplace(char *s, char old, char new);
+char *strreplace(char *, char, char);
 
 extern void kfree_const(const void *x);
 

I didn't see and could not find any reply to v1. Who is that comment addressed to? Linus?

Please only change the prototype, not the function. Might as well remove the argument names in the prototype.

Let's not make the C code uglier for no reason. The fact that C++ screwed up and thought that "new" can't be used as a variable name is no reason not to do it in C code.

Similarly, we don't make C code use the insane C++ pointer caring rules.

Linus

Quoted 2 lines · Randy Dunlap

I didn't see and could not find any reply to v1.  Who is that comment addressed to?  Linus?

Yes, this was addressed to Linus. He CC'd the mailing list, but I could not

Quoted 4 lines · find it either. Here is what he

Please only change the prototype, not the function. Might as well remove the argument names in the prototype.

Quoted 7 lines

Let's not make the C code uglier for no reason. The fact that C++ screwed up and thought that "new" can't be used as a variable name is no reason not to do it in C code.

Similarly, we don't make C code use the insane C++ pointer caring rules.

   Linus

-- Matt Ullman

(Matt, you've got an unusual reply-to header)