4.7 regression - ACPICA: Hardware: Enhance acpi_hw_validate_register() with access_width/bit_offset awareness
In my aging (ok old) HP DL980 G7 ->access_width may be either 0 or max_bit_width, the later inspiring cpufreq to say go away. The below made box a happy camper again.
ACPI Error: Unsupported register access width: 0x40 (20160422/hwregs-165)
Dinged-up-by: my little hammer
--- drivers/acpi/acpica/hwregs.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/acpi/acpica/hwregs.c +10 -3
@@ -83,7 +83,7 @@ acpi_hw_write_multiple(u32 value,static u8 acpi_hw_get_access_bit_width (struct acpi_generic_address *reg,u8 max_bit_width) { -if (!reg->access_width) { +if (!reg->access_width || reg->access_width == max_bit_width) {if (reg->space_id ==ACPI_ADR_SPACE_SYSTEM_IO ) { max_bit_width =32 ; }
@@ -152,9 +152,16 @@ acpi_hw_validate_register(struct acpi_gereturn (AE_SUPPORT ); } -/* Validate the access_width */ +/* Validate the access_width, or bit_width for old register descriptors */ -if (reg->access_width >4 ) { +if ((!reg->access_width || reg->access_width == max_bit_width)) { +if (reg->bit_width !=8 && reg->bit_width !=16 && + reg->bit_width !=32 && reg->bit_width != max_bit_width) { +ACPI_ERROR ((AE_INFO ,"Unsupported register bit width: 0x%X" , + reg->bit_width)); +return (AE_SUPPORT ); + } + }else if (reg->access_width >4 ) {ACPI_ERROR ((AE_INFO ,"Unsupported register access width: 0x%X" , reg->access_width));
Hi, Mike
Quoted 5 lines
From: Mike Galbraith [mailto:[email protected]]
Subject: 4.7 regression - ACPICA: Hardware: Enhanceacpi_hw_validate_register()with access_width/bit_offset awarenessIn my aging (ok old) HP DL980 G7
[Lv Zheng]
Which may mean Windows Vista cannot run on this machine, and you need to use quirks to run recent Linux. Could you try to boot it with one of the following parameters or both of the parameters:
acpi=rsdt
Oracpi_force_32bit_fadt_addr
TBH, Windows preference of RSDT/XSDT and the preference of old 32-bit register/new GAS register descriptor are unknown to us. But we prepared quirk for the users that my require an explicit preference to use the old platforms.
Please also send us the acpidump/dmidecode outputs for confirmation.
Quoted 6 lines
->access_width may be either 0 or
max_bit_width, the later inspiring cpufreq to say go away. The below made box a happy camper again.ACPI Error: Unsupported register access width:
0x40(20160422/hwregs-
165)
[Lv Zheng]
According to the ACPI specification.
The valid access size is:
Specifies access size.
0 Undefined (legacy reasons)
1 Byte access
2 Word access
3 Dword access
4 QWord access
0x40 is a too big number.
So you surely need a quirk because the value filled by the BIOS is not spec compliant.
Thanks and best regards
-Lv
Quoted 40 lines
Dinged-up-by: my little hammer
--- drivers/acpi/acpica/hwregs.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)drivers/acpi/acpica/hwregs.c +1
-1@@ -83,7 +83,7 @@ acpi_hw_write_multiple(u32 value,static u8 acpi_hw_get_access_bit_width (struct acpi_generic_address *reg,u8 max_bit_width) { -if (!reg->access_width) { +if (!reg->access_width || reg->access_width == max_bit_width) {if (reg->space_id ==ACPI_ADR_SPACE_SYSTEM_IO ) { max_bit_width =32 ;drivers/acpi/acpica/hwregs.c +1
-1}@@ -152,9 +152,16 @@ acpi_hw_validate_register(struct acpi_gereturn (AE_SUPPORT ); } -/* Validate the access_width */ +/* Validate the access_width, or bit_width for old register descriptors */
drivers/acpi/acpica/hwregs.c +3
-1-if (reg->access_width >4 ) { + if ((!reg->access_width || reg->access_width == max_bit_width)) { + if (reg->bit_width != 8 && reg->bit_width != 16 && + reg->bit_width != 32 && reg->bit_width !=
max_bit_width) {drivers/acpi/acpica/hwregs.c +1
-0+ ACPI_ERROR((AE_INFO, "Unsupported register bitwidth: 0x%X",
drivers/acpi/acpica/hwregs.c +4
-0+ reg->bit_width)); +return (AE_SUPPORT ); + } + }else if (reg->access_width >4 ) {ACPI_ERROR ((AE_INFO ,"Unsupported register access width: 0x%X" , reg->access_width));
Quoted 4 lines · Lv
Could you try to boot it with one of the following parameters or both of the parameters:
acpi=rsdt
Oracpi_force_32bit_fadt_addr
Box was unimpressed by either or both.
Quoted 1 line
Please also send us the acpidump/dmidecode outputs for confirmation.
(offlist)
-Mike
PATCH 1/1 cpufreq/pcc-cpufreq: Fix doorbell.access_width
In reply to Mike GalbraithCommit 920de6ebfab8 apparently exposed a latent bug, doorbell.access_width is initialized to 64, but per Lv Zheng, it should be 4, and indeed, making that change does bring pcc-cpufreq back to life.
--- drivers/cpufreq/pcc-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/pcc-cpufreq.c +1 -1
@@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void doorbell.space_id = reg_resource->space_id; doorbell.bit_width = reg_resource->bit_width; doorbell.bit_offset = reg_resource->bit_offset; - doorbell.access_width =64 ; + doorbell.access_width =4 ; doorbell.address = reg_resource->address; pr_debug("probe: doorbell: space_id is %d, bit_width is %d, "
Re: [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width
Quoted 13 lines · Mike Galbraith
Commit
920de6ebfab8apparently exposed a latent bug, doorbell.access_width is initialized to 64, but per Lv Zheng, it should be 4, and indeed, making that change does bring pcc-cpufreq back to life.Suggested-by Lv Zheng <[email protected]>Signed-off-by Mike Galbraith <[email protected]>--- drivers/cpufreq/pcc-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/pcc-cpufreq.c static int __init pcc_cpufreq_probe(void · line 493
Quoted 8 lines
drivers/cpufreq/pcc-cpufreq.c +1
-1@@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void doorbell.space_id = reg_resource->space_id; doorbell.bit_width = reg_resource->bit_width; doorbell.bit_offset = reg_resource->bit_offset; - doorbell.access_width =64 ; + doorbell.access_width =4 ; doorbell.address = reg_resource->address; pr_debug("probe: doorbell: space_id is %d, bit_width is %d, "
OK, I picked this up from the LKML patchwork (will push to Linus tomorrow), but next time please CC patches related to ACPI to linux-acpi and PM patches to linux-pm (so this one should have gone to both, ideally). They are much easier to handle/review then and more people are likely to look at them too.
Thanks,
Rafael