Skip to contentSkip to conversation

powerpc/pci: Reduce log level of PCI I/O space warning

PATCH Applied Benjamin Herrenschmidt 3 participants 3 messages Jun 22, 2016 – Jun 28, 2016 PowerPC

lore
Share & tools
lore

Benjamin Herrenschmidt

author
#0 lore raw

PATCH 1/1 powerpc/pci: Reduce log level of PCI I/O space warning

If a PHB has no I/O space, there's no need to make it look like something bad happened, a pr_debug() is plenty enough since this is the case of all our modern POWER chips.

Signed-off-by Benjamin Herrenschmidt <[email protected]>
---
 arch/powerpc/kernel/pci-common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/kernel/pci-common.c +3 -3
index 2a67b16..3ab1f7b 100644
@@ -1487,9 +1487,9 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose,
 	res = &hose->io_resource;
 
 	if (!res->flags) {
-		pr_info("PCI: I/O resource not set for host"
-		       " bridge %s (domain %d)\n",
-		       hose->dn->full_name, hose->global_number);
+		pr_debug("PCI: I/O resource not set for host"
+			 " bridge %s (domain %d)\n",
+			 hose->dn->full_name, hose->global_number);
 	} else {
 		offset = pcibios_io_space_offset(hose);
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Benjamin Herrenschmidt

If a PHB has no I/O space, there's no need to make it look like something bad happened, a pr_debug() is plenty enough since this is the case of all our modern POWER chips.

Signed-off-by Benjamin Herrenschmidt <[email protected]>
Reviewed-by Gavin Shan <[email protected]>
Quoted 27 lines

---
arch/powerpc/kernel/pci-common.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/kernel/pci-common.c +3 -3
index 2a67b16..3ab1f7b 100644
@@ -1487,9 +1487,9 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose,
 	res = &hose->io_resource;
 
 	if (!res->flags) {
-		pr_info("PCI: I/O resource not set for host"
-		       " bridge %s (domain %d)\n",
-		       hose->dn->full_name, hose->global_number);
+		pr_debug("PCI: I/O resource not set for host"
+			 " bridge %s (domain %d)\n",
+			 hose->dn->full_name, hose->global_number);
 	} else {
 		offset = pcibios_io_space_offset(hose);

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev