configure: Fix logic to show connlabel support
PATCH 1/1 configure: Fix logic to show connlabel support
With the earlier logic, when libnfnetlink and libnetfilter_conntrack were not installed, all the warnings showed up correctly but the final configuration showed:
connlabel support: yes
which was faulty.
This was happening because connlabel module was blacklisted first and then set to "no" if package requirements were not met. After this patch, iptables configuration shows up correctly.
Fixes commit 3b7a227 (configure: Show support for connlabel)
Tested before and after installing the dependencies.
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
@@ -173,9 +173,9 @@ if test "x$enable_connlabel" = "xyes"; then [nfconntrack=1], [nfconntrack=0]) if test "$nfconntrack" -ne 1; then + enable_connlabel="no"; blacklist_modules="$blacklist_modules connlabel"; echo "WARNING: libnetfilter_conntrack not found, connlabel match will not be built"; - enable_connlabel = "no"; fi; else blacklist_modules="$blacklist_modules connlabel";
Signature · 1 line
2.7.4
Florian Westphal
maintainerQuoted 9 lines · Shivani Bhardwaj
With the earlier logic, when libnfnetlink and
libnetfilter_conntrackwere not installed, all the warnings showed up correctly but the final configuration showed:connlabel support: yes
which was faulty.
This was happening because connlabel module was blacklisted first and then set to "no" if package requirements were not met.
its because ...
configure.ac if test "x$enable_connlabel" = "xyes"; then · line 178
Quoted 12 lines
configure.ac +1
-1@@ -173,9 +173,9 @@ if test "x$enable_connlabel" = "xyes"; then [nfconntrack=1], [nfconntrack=0]) if test "$nfconntrack" -ne 1; then + enable_connlabel="no"; blacklist_modules="$blacklist_modules connlabel"; echo "WARNING: libnetfilter_conntrack not found, connlabel match will not be built"; - enable_connlabel = "no";
... of the space around the '=', shell tried to execute 'enable_connlabel' command here.
Quoted 20 lines · Florian Westphal
Quoted 9 lines · Shivani Bhardwaj
With the earlier logic, when libnfnetlink and
libnetfilter_conntrackwere not installed, all the warnings showed up correctly but the final configuration showed:connlabel support: yes
which was faulty.
This was happening because connlabel module was blacklisted first and then set to "no" if package requirements were not met.its because ...
Quoted 7 lines
configure.ac +0
-0@@ -173,9 +173,9 @@ if test "x$enable_connlabel" = "xyes"; then [nfconntrack=1], [nfconntrack=0])
Quoted 8 lines
configure.ac if test "x$enable_connlabel" = "xyes"; then · line 178
Quoted 5 lines
configure.ac +1
-1if test "$nfconntrack" -ne 1; then + enable_connlabel="no"; blacklist_modules="$blacklist_modules connlabel"; echo "WARNING: libnetfilter_conntrack not found, connlabel match will not be built"; - enable_connlabel = "no";... of the space around the '=', shell tried to execute '
enable_connlabel' command here.
Thanks. I'm sorry for misinterpreting and writing the wrong message. I shall resend the patch.