staging: rtl8188eu: Remove no more used functions and variables
PATCH v2 1/1 staging: rtl8188eu: Remove no more used functions and variables
Remove the functions and variables from rtw_security.c that are no more necessary since the patch that replaces getcrc32() with crc32_le():
https://lore.kernel.org/lkml/[email protected]/
---
v1 -> v2:
Update the commit message with the URL of v2 of the above-mentioned patch.
Please, apply this patch after the above-mentioned one to make the code build with no errors.
drivers/staging/rtl8188eu/core/rtw_security.c | 36 ------------------- 1 file changed, 36 deletions(-)
drivers/staging/rtl8188eu/core/rtw_security.c +0 -36
@@ -76,42 +76,6 @@ static void arcfour_encrypt(struct arc4context *parc4ctx, u8 *dest, u8 *src, u32 dest[i] = src[i] ^ (unsigned char )arcfour_byte (parc4ctx); } -static int bcrc32initialized; -static u32 crc32_table[256 ]; - -static u8 crc32_reverseBit (u8 data) -{ -return (u8)((data <<7 ) &0x80 ) | ((data <<5 ) &0x40 ) | ((data <<3 ) &0x20 ) | - ((data <<1 ) &0x10 ) | ((data >>1 ) &0x08 ) | ((data >>3 ) &0x04 ) | - ((data >>5 ) &0x02 ) | ((data >>7 ) &0x01 ); -} - -static void crc32_init (void ) -{ -int i, j; -u32 c; -u8 *p = (u8 *)&c, *p1; -u8 k; - -if (bcrc32initialized ==1 ) -return ; - - c =0x12340000 ; - -for (i =0 ; i <256 ; ++i) { - k =crc32_reverseBit ((u8 )i); -for (c = ((u32 )k) <<24 , j =8 ; j >0 ; --j) - c = c &0x80000000 ? (c <<1 ) ^CRC32_POLY : (c <<1 ); - p1 = (u8 *)&crc32_table[i]; - - p1[0 ] =crc32_reverseBit (p[3 ]); - p1[1 ] =crc32_reverseBit (p[2 ]); - p1[2 ] =crc32_reverseBit (p[1 ]); - p1[3 ] =crc32_reverseBit (p[0 ]); - } - bcrc32initialized =1 ; -} -/* Need to consider the fragment situation */ void rtw_wep_encrypt (struct adapter *padapter,struct xmit_frame *pxmitframe) {
Signature · 1 line
2.32.0
Greg Kroah-Hartman
maintainerQuoted 3 lines · Fabio M. De Francesco
Remove the functions and variables from
rtw_security.cthat are no more necessary since the patch that replacesgetcrc32()withcrc32_le():
https://lore.kernel.org/lkml/[email protected]/
Can you send this as a patch series?
confused,
greg k-h
Quoted 7 lines · CEST Greg Kroah-Hartman
Quoted 3 lines · Fabio M. De Francesco
Remove the functions and variables from
rtw_security.cthat are no more necessary since the patch that replacesgetcrc32()withcrc32_le():
https://lore.kernel.org/lkml/[email protected]/Can you send this as a patch series?
Sure. I've just sent a v3 series with two patches.
Thanks,
Fabio
Quoted 4 lines
confused,
greg k-h